Skip to content

Commit 168887d

Browse files
author
Chuck Dumont
authored
Merge pull request #209 from chuckdumont/work
Fix define function context in async mode
2 parents 9dd5451 + ce20cae commit 168887d

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

runtime/DojoAMDMainTemplate.runtime.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,7 @@ module.exports = {
200200
// Unwrap wrapped promises
201201
deps = asyncUnwrapDependencies(deps);
202202
module && (module.exports = exports);
203-
var result = defFactory.apply(exports, deps);
203+
var result = defFactory.apply(null, deps);
204204
if (typeof module === 'function') {
205205
// module is actually a callback function
206206
module(result);

test/ErrorTestCases/misc/asyncVersionFailure/expectedError.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ const major = parseInt(require("webpack/package.json").version.split('.')[0]);
22
const result = {};
33
if (major < 4) {
44
result.test = function(error) {
5-
return /Async mode require webpack 4 or greater/.test(error.message);
5+
return /Async mode requires webpack 4.28.4 or greater/.test(error.message);
66
};
77
}
88
module.exports = result;

0 commit comments

Comments
 (0)