Make internalizing anonymous dicts support IMapping, not just its subclass IDict.

Author: jamadden

CHANGES.rst

@@ -6,7 +6,9 @@
 3.2.1 (unreleased)
 ==================
 
-- Nothing changed yet.
+- Make internalizing anonymous dictionary objects
+  support ``IMapping`` fields, rather than only its subclass
+  ``IDict``.
 
 
 3.2.0 (2026-05-19)

src/nti/externalization/_datastructures.pxd

@@ -32,7 +32,7 @@ cdef make_repr
 cdef isSyntheticKey
 cdef find_most_derived_interface
 cdef NotGiven
-cdef IDict_providedBy
+cdef IMapping_providedBy
 cdef IObject_providedBy
 cdef _anonymous_dict_factory
 

src/nti/externalization/datastructures.py

@@ -19,7 +19,7 @@
 from zope import interface
 from zope import schema
 from zope.component import getUtility
-from zope.schema.interfaces import IDict
+from zope.schema.interfaces import IMapping
 from zope.schema.interfaces import IObject
 from zope.schema.interfaces import SchemaNotProvided
 
@@ -49,7 +49,7 @@
 StandardExternalFields = get_standard_external_fields()
 StandardInternalFields = get_standard_internal_fields()
 DEFAULT_EXTERNALIZATION_POLICY = get_default_externalization_policy()
-IDict_providedBy = IDict.providedBy
+IMapping_providedBy = IMapping.providedBy
 IObject_providedBy = IObject.providedBy
 
 __all__ = [
@@ -694,13 +694,16 @@ def find_factory_for_named_value(self, key, value):
         remove this limitation is to subclass this object.
 
         If no registered factory is found, and the schema field is
-        a `zope.schema.Dict` with a value type of `zope.schema.Object`,
+        a `zope.schema.Mapping` with a value type of `zope.schema.Object`,
         then we return a factory which will update the object in place.
 
         .. versionchanged:: 1.0a6
            Only return an anonymous factory for ``IDict`` fields when
            it wants objects for the value.
 
+        .. versionchanged:: NEXT
+           Use ``IMapping`` instead of ``IDict`` to be more general.
+
         """
         factory = AbstractDynamicObjectIO.find_factory_for_named_value(self, key, value)
         if factory is None: # pylint:disable=too-many-nested-blocks
@@ -727,12 +730,12 @@ def find_factory_for_named_value(self, key, value):
 
                 if (
                         factory is None
-                        and IDict_providedBy(field) # pylint:disable=no-value-for-parameter
+                        and IMapping_providedBy(field) # pylint:disable=no-value-for-parameter
                         and isinstance(value, dict)
                         and IObject_providedBy(field.value_type) # pylint:disable=no-value-for-parameter
                 ):
-                    # If is no factory found, check to see if the
-                    # schema field is a Dict with a complex value type, and if
+                    # If there is no factory found, check to see if the
+                    # schema field is a Mapping with a complex value type, and if
                     # so, automatically update it in place. The alternative
                     # requires the user to use a ZCML directive for each such
                     # dict field.

src/nti/externalization/tests/test_datastructures.py

@@ -549,14 +549,14 @@ class O(object):
         assert_that(factory, is_(none()))
 
     def test_factory_for_dict_with_object_value(self):
-        from zope.schema import Dict
+        from zope.schema import Mapping
         from zope.schema import Object
 
         class I2(interface.Interface):
             pass
 
         class I(interface.Interface):
-            field = Dict(
+            field = Mapping(
                 title='A blank field',
                 value_type=Object(I2)
             )

src/nti/externalization/zcml.py

@@ -244,7 +244,6 @@ def _ap_find_package_name(_cls):
     # The plus side is that now that we are using component_zcml.utility()
     # to register legacy class factories too, there's not much harm in
     # initing the class early.
-
     legacy_factories = cls_iio.__class_init__()
 
     # Now that it's initted, register the factories