Skip to content

Commit 0ce5449

Browse files
committed
fix(app): Load directory trees by git hash key instead of key/path composite id
1 parent 7bef764 commit 0ce5449

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

packages/openneuro-app/src/scripts/dataset/files/__tests__/file-tree-unloaded-directory.spec.jsx

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ describe("FileTreeUnloadedDirectory component", () => {
3838
expect(
3939
mergeNewFiles(dir)(defaultObj, { fetchMoreResult: updatedObj }).dataset
4040
.draft.files,
41-
).toEqual([a, b, { ...c, filename: "sub-01:c" }])
41+
).toEqual([a, b, { ...c, id: "sub-01:91011", filename: "sub-01:c" }])
4242
})
4343
it("works with snapshots", () => {
4444
const dir = { filename: "sub-01", directory: true }
@@ -50,7 +50,11 @@ describe("FileTreeUnloadedDirectory component", () => {
5050
expect(
5151
mergeNewFiles(dir, "1.0.0")(defaultObj, { fetchMoreResult: updatedObj })
5252
.snapshot.files,
53-
).toEqual([dir, a, b, { ...c, filename: "sub-01:c" }])
53+
).toEqual([dir, a, b, {
54+
...c,
55+
id: "sub-01:91011",
56+
filename: "sub-01:c",
57+
}])
5458
})
5559
})
5660
})

packages/openneuro-app/src/scripts/dataset/files/file-tree-unloaded-directory.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ export const fetchMoreDirectory = (
7474
) =>
7575
fetchMore({
7676
query: snapshotTag ? SNAPSHOT_FILES_QUERY : DRAFT_FILES_QUERY,
77-
variables: { datasetId, snapshotTag, tree: directory.id },
77+
variables: { datasetId, snapshotTag, tree: directory.key },
7878
updateQuery: mergeNewFiles(directory, snapshotTag),
7979
})
8080

0 commit comments

Comments
 (0)