Skip to content

Commit 149a8ea

Browse files
committed
fix(app): Add filetype parameter for nwb/edf files to neurosift viewer
1 parent b401010 commit 149a8ea

File tree

3 files changed

+20
-9
lines changed

3 files changed

+20
-9
lines changed

packages/openneuro-app/src/scripts/dataset/files/file-viewer-type.jsx

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import FileViewerJson from "./viewers/file-viewer-json.jsx"
66
import FileViewerTsv from "./viewers/file-viewer-tsv.jsx"
77
import FileViewerCsv from "./viewers/file-viewer-csv.jsx"
88
import FileViewerHtml from "./viewers/file-viewer-html.jsx"
9-
import { FileViewerEdf } from "./viewers/file-viewer-edf"
9+
import { FileViewerNeurosift } from "./viewers/file-viewer-neurosift"
1010

1111
/**
1212
* Choose the right viewer for each file type
@@ -35,8 +35,10 @@ const FileViewerType = ({ path, url, data }) => {
3535
return <FileViewerCsv data={data} />
3636
} else if (path.endsWith(".html")) {
3737
return <FileViewerHtml data={data} />
38-
} else if (path.endsWith(".edf") || path.endsWith(".nwb")) {
39-
return <FileViewerEdf url={url} />
38+
} else if (path.endsWith(".edf")) {
39+
return <FileViewerNeurosift url={url} filetype="edf" />
40+
} else if (path.endsWith(".nwb")) {
41+
return <FileViewerNeurosift url={url} filetype="nwb" />
4042
} else {
4143
return (
4244
<div className="file-viewer-fallback">
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,15 @@
11
import React from "react"
22
import { render, screen } from "@testing-library/react"
3-
import { FileViewerEdf } from "../file-viewer-edf"
3+
import { FileViewerNeurosift } from "../file-viewer-neurosift"
44

55
describe("File Viewer - EDF", () => {
66
it("renders an iframe with a src value", () => {
7-
render(<FileViewerEdf url="https://example.com/example.edf" />)
7+
render(
8+
<FileViewerNeurosift
9+
url="https://example.com/example.edf"
10+
filetype="edf"
11+
/>,
12+
)
813
expect(screen.getByTitle("Neurosift viewer")).toBeInTheDocument()
914
})
1015
})

packages/openneuro-app/src/scripts/dataset/files/viewers/file-viewer-edf.tsx renamed to packages/openneuro-app/src/scripts/dataset/files/viewers/file-viewer-neurosift.tsx

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,16 +7,20 @@ const ScaledIframe = styled.iframe`
77
border: none;
88
`
99

10-
interface FileViewerEdfProps {
10+
interface FileViewerNeurosiftProps {
1111
url: string
12+
filetype: "nwb" | "edf"
1213
}
1314

1415
/**
1516
* Viewer embedding Neurosift for EDF and NWB data
1617
*/
17-
export const FileViewerEdf = ({ url }: FileViewerEdfProps) => {
18-
const viewerUrl = `https://neurosift.app/?p=/edf&embedded=1&url=${url}`
18+
export const FileViewerNeurosift = (
19+
{ url, filetype }: FileViewerNeurosiftProps,
20+
) => {
21+
const viewerUrl =
22+
`https://neurosift.app/?p=/${filetype}&embedded=1&url=${url}`
1923
return <ScaledIframe src={viewerUrl} title="Neurosift viewer" />
2024
}
2125

22-
export default FileViewerEdf
26+
export default FileViewerNeurosift

0 commit comments

Comments
 (0)