Skip to content

Commit a49622a

Browse files
committed
fix(app): Show user name with ORCID/email on permissions view
1 parent 599e229 commit a49622a

File tree

3 files changed

+11
-3
lines changed

3 files changed

+11
-3
lines changed

packages/openneuro-app/src/scripts/datalad/dataset/dataset-query-fragments.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,7 @@ export const PERMISSION_FRAGMENT = gql`
7575
id
7676
email
7777
orcid
78+
name
7879
}
7980
level
8081
}

packages/openneuro-app/src/scripts/dataset/routes/manage-permissions.jsx

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,13 @@ const description = {
1515
}
1616

1717
export const PermissionRow = (
18-
{ datasetId, userId, userEmail, userOrcid, access },
18+
{ datasetId, userId, userName, userEmail, userOrcid, access },
1919
) => (
2020
<div className="data-table-content">
21+
<span>
22+
<label>User:</label>
23+
{userName}
24+
</span>
2125
{userOrcid
2226
? (
2327
<span>
@@ -46,6 +50,7 @@ export const PermissionRow = (
4650
PermissionRow.propTypes = {
4751
datasetId: PropTypes.string,
4852
userId: PropTypes.string,
53+
userName: PropTypes.string,
4954
userEmail: PropTypes.string,
5055
userOrcid: PropTypes.string,
5156
access: PropTypes.oneOf(["ro", "rw", "admin"]),
@@ -54,7 +59,8 @@ PermissionRow.propTypes = {
5459
export const ShareTable = ({ datasetId, permissions }) => (
5560
<>
5661
<div className="data-table-header">
57-
<span>Email</span>
62+
<span>Name</span>
63+
<span>Reference</span>
5864
<span>Access</span>
5965
<span>Edit</span>
6066
</div>
@@ -63,6 +69,7 @@ export const ShareTable = ({ datasetId, permissions }) => (
6369
<PermissionRow
6470
datasetId={datasetId}
6571
userId={perm.user.id}
72+
userName={perm.user.name}
6673
userEmail={perm.user.email}
6774
userOrcid={perm.user.orcid}
6875
access={perm.level}

packages/openneuro-app/src/scripts/scss/dataset/dataset-tool.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@
5454
}
5555
> span {
5656
display: block;
57-
min-width: 33.3333%;
57+
min-width: 25%;
5858
margin-bottom: 11px;
5959
label {
6060
font-weight: bold;

0 commit comments

Comments
 (0)