Merge pull request #3361 from OpenNeuroOrg/validation-no-issues-fix

fix(app): Show "valid" if schema validation has returned no issues but ran successfully

Author: nellh

packages/openneuro-app/src/scripts/dataset/components/ValidationBlock.tsx

@@ -50,7 +50,7 @@ export const ValidationBlock: React.FC<ValidationBlockProps> = ({
     )
   } else {
     // If data exists, populate this. Otherwise we show pending.
-    if (validation?.warnings + validation?.errors > 0) {
+    if (validation) {
       return (
         <div className="validation-accordion">
           <Validation

packages/openneuro-app/src/scripts/dataset/components/__tests__/ValidationBlock.spec.tsx

@@ -44,4 +44,14 @@ describe("ValidationBlock component", () => {
     render(<ValidationBlock datasetId="ds000031" />)
     expect(screen.getByText("Validation Pending")).toBeInTheDocument()
   })
+  it("renders validation if `validation` is present but errors and warnings are zero", () => {
+    render(
+      <ValidationBlock
+        datasetId="ds000031"
+        validation={{ errors: 0, warnings: 0, issues: [], codeMessages: [] }}
+      />,
+    )
+    expect(screen.getByText("Valid")).toBeInTheDocument()
+    expect(screen.queryByText("Validation Pending")).not.toBeInTheDocument()
+  })
 })