Merge pull request #3630 from OpenNeuroOrg/fix/datacite-sentry-log

nellh · web-flow · commit b5ecef0dc0b0 · 2025-11-07T15:04:29.000-08:00
update sentry to only log if dataset has datacite
diff --git a/packages/openneuro-server/src/datalad/contributors.ts b/packages/openneuro-server/src/datalad/contributors.ts
@@ -67,7 +67,12 @@ export const contributors = async (
     }
 
     // --- Dataset type but no contributors ---
-    if (resourceType === "Dataset") {
+    // Only log if a Datacite file actually exists
+    if (
+      dataciteData?.data?.attributes &&
+      resourceType === "Dataset" &&
+      !attributes?.contributors?.length
+    ) {
       Sentry.captureMessage(
         `Datacite file for ${datasetId}:${revisionShort} is Dataset type but provided no contributors.`,
       )

Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,12 @@ export const contributors = async (`
`67`	`67`	`}`
`68`	`68`
`69`	`69`	`// --- Dataset type but no contributors ---`
`70`		`- if (resourceType === "Dataset") {`
	`70`	`+ // Only log if a Datacite file actually exists`
	`71`	`+ if (`
	`72`	`+ dataciteData?.data?.attributes &&`
	`73`	`+ resourceType === "Dataset" &&`
	`74`	`+ !attributes?.contributors?.length`
	`75`	`+ ) {`
`71`	`76`	`Sentry.captureMessage(`
`72`	`77`	`Datacite file for ${datasetId}:${revisionShort} is Dataset type but provided no contributors.`,
`73`	`78`	`)`