Merge pull request #3472 from OpenNeuroOrg/download-filename-fix

nellh · web-flow · commit cf223bd63dda · 2025-05-28T17:45:34.000-07:00
fix(app): Include a suggested filename in download links
diff --git a/packages/openneuro-app/src/scripts/dataset/files/__tests__/__snapshots__/file.spec.jsx.snap b/packages/openneuro-app/src/scripts/dataset/files/__tests__/__snapshots__/file.spec.jsx.snap
@@ -29,7 +29,7 @@ exports[`File component > renders for dataset snapshots 1`] = `
         >
           <a
             aria-label="download file"
-            download=""
+            download="README"
             href="/crn/datasets/ds001/snapshots/1.0.0/files/README"
           >
             <i
@@ -90,7 +90,7 @@ exports[`File component > renders with common props 1`] = `
         >
           <a
             aria-label="download file"
-            download=""
+            download="README"
             href="/crn/datasets/ds001/files/README"
           >
             <i
diff --git a/packages/openneuro-app/src/scripts/dataset/files/file.tsx b/packages/openneuro-app/src/scripts/dataset/files/file.tsx
@@ -149,7 +149,7 @@ const File = ({
                 <a
                   href={urls?.[0] ||
                     apiPath(datasetId, snapshotTag, filePath(path, filename))}
-                  download
+                  download={filename}
                   aria-label="download file"
                 >
                   <i className="fa fa-download" />

Original file line number	Diff line number	Diff line change
@@ -29,7 +29,7 @@ exports[`File component > renders for dataset snapshots 1`] = `
`29`	`29`	`>`
`30`	`30`	`<a`
`31`	`31`	`aria-label="download file"`
`32`		`- download=""`
	`32`	`+ download="README"`
`33`	`33`	`href="/crn/datasets/ds001/snapshots/1.0.0/files/README"`
`34`	`34`	`>`
`35`	`35`	`<i`
@@ -90,7 +90,7 @@ exports[`File component > renders with common props 1`] = `
`90`	`90`	`>`
`91`	`91`	`<a`
`92`	`92`	`aria-label="download file"`
`93`		`- download=""`
	`93`	`+ download="README"`
`94`	`94`	`href="/crn/datasets/ds001/files/README"`
`95`	`95`	`>`
`96`	`96`	`<i`
Original file line number	Diff line number	Diff line change
`@@ -149,7 +149,7 @@ const File = ({`
`149`	`149`	`<a`
`150`	`150`	`href={urls?.[0] \|\|`
`151`	`151`	`apiPath(datasetId, snapshotTag, filePath(path, filename))}`
`152`		`- download`
	`152`	`+ download={filename}`
`153`	`153`	`aria-label="download file"`
`154`	`154`	`>`
`155`	`155`	`<i className="fa fa-download" />`