fix(app): Remove no-op value mutation TwoHandleRange change handlers

nellh · nellh · commit cf5956d60bd4 · 2024-10-23T10:41:43.000-07:00
diff --git a/packages/openneuro-components/src/range/TwoHandleRange.tsx b/packages/openneuro-components/src/range/TwoHandleRange.tsx
@@ -66,7 +66,6 @@ export const TwoHandleRange: React.FC<TwoHandleRangeProps> = ({
       Math.min(Number(changeEvent.target.value), value[1] - 1),
       step,
     )
-    value[0] = discreteValue
     onChange([discreteValue, value[1]])
   }
   const maxChangeHandler = (
@@ -79,7 +78,6 @@ export const TwoHandleRange: React.FC<TwoHandleRangeProps> = ({
       Math.max(Number(changeEvent.target.value), value[0] + 1),
       step,
     )
-    value[1] = discreteValue
     onChange([value[0], discreteValue])
   }
 

Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,6 @@ export const TwoHandleRange: React.FC<TwoHandleRangeProps> = ({`
`66`	`66`	`Math.min(Number(changeEvent.target.value), value[1] - 1),`
`67`	`67`	`step,`
`68`	`68`	`)`
`69`		`- value[0] = discreteValue`
`70`	`69`	`onChange([discreteValue, value[1]])`
`71`	`70`	`}`
`72`	`71`	`const maxChangeHandler = (`
`@@ -79,7 +78,6 @@ export const TwoHandleRange: React.FC<TwoHandleRangeProps> = ({`
`79`	`78`	`Math.max(Number(changeEvent.target.value), value[0] + 1),`
`80`	`79`	`step,`
`81`	`80`	`)`
`82`		`- value[1] = discreteValue`
`83`	`81`	`onChange([value[0], discreteValue])`
`84`	`82`	`}`
`85`	`83`