chore(lint): Remaining eslint refactor fixes

Author: nellh

packages/openneuro-app/src/scripts/common/containers/__tests__/header.spec.tsx

@@ -10,7 +10,6 @@ vi.mock("../../../uploader/uploader-view.jsx", () => ({
   default: () => "mocked UploaderView",
 }))
 vi.mock("react-router-dom", async () => ({
-  // @ts-ignore-check
   ...(await vi.importActual("react-router-dom")),
   useNavigate: () => navigate,
 }))

packages/openneuro-app/src/scripts/common/content/terms.tsx

@@ -1,7 +1,7 @@
-import React, { ReactElement } from "react"
+import React from "react"
 
 /** Terms and conditions content. */
-export function Terms(): ReactElement {
+export function Terms(): React.ReactElement {
   return (
     <>
       <p>

packages/openneuro-app/src/scripts/components/data-table.tsx

@@ -4,13 +4,14 @@ import {
   flexRender,
   getCoreRowModel,
   getSortedRowModel,
-  SortingState,
   useReactTable,
 } from "@tanstack/react-table"
+import type { SortingState } from "@tanstack/react-table"
 import styled from "@emotion/styled"
 import { format, isValid, parse } from "date-fns"
 
 interface DataTableProps {
+  /* eslint-disable-next-line @typescript-eslint/no-explicit-any */
   data: any[]
   downloadFilename?: string
   hideColumns?: string[]
@@ -55,6 +56,7 @@ export function extractDateString(dateString) {
   return false
 }
 
+/* eslint-disable-next-line @typescript-eslint/no-explicit-any */
 function CellFormat(props): any {
   const value = props.getValue()
   let extractedDate
@@ -86,6 +88,7 @@ export function DataTable<T>({
       Object.keys(data[0])
         .filter((name) => !hideColumns.includes(name))
         .map((name) =>
+          // eslint-disable-next-line @typescript-eslint/no-explicit-any
           columnHelper.accessor(name as any, {
             header: name,
             cell: CellFormat,

packages/openneuro-app/src/scripts/datalad/mutations/snapshot.tsx

@@ -33,7 +33,7 @@ const CreateSnapshotMutation = ({ datasetId, tag, changes }) => {
 interface SnapshotDatasetProps {
   datasetId: string
   tag: string
-  changes: Array<string>
+  changes: string[]
 }
 
 const SnapshotDataset = ({ datasetId, tag, changes }: SnapshotDatasetProps) => (

packages/openneuro-app/src/scripts/dataset/comments/comment-editor.jsx

@@ -20,7 +20,7 @@ const CommentEditor = ({
   )
   const doAfterSubmit = () => {
     setEditorState(EditorState.createEmpty())
-    done && done()
+    if (done) done()
   }
   const disabled = editorState.getUndoStack().size === 0
   return (

packages/openneuro-app/src/scripts/dataset/components/DatasetToolButton.tsx

@@ -1,5 +1,6 @@
 import React from "react"
-import styled, { StyledComponent } from "@emotion/styled"
+import styled from "@emotion/styled"
+import type { StyledComponent } from "@emotion/styled"
 import { Link } from "react-router-dom"
 import { Tooltip } from "@openneuro/components/tooltip"
 import { Icon } from "@openneuro/components/icon"

packages/openneuro-app/src/scripts/dataset/components/DatasetTools.tsx

@@ -1,11 +1,11 @@
 import React from "react"
 import { DatasetToolButton } from "./DatasetToolButton"
-import styled, { StyledComponent } from "@emotion/styled"
+import styled from "@emotion/styled"
+import type { StyledComponent } from "@emotion/styled"
 import { useAgreement } from "../../components/agreement"
 
-interface DatasetToolStyleProps {}
-
-export const DatasetToolStyle: StyledComponent<DatasetToolStyleProps> = styled
+// eslint-disable-next-line @typescript-eslint/no-empty-object-type
+export const DatasetToolStyle: StyledComponent<{}> = styled
   .span`
   display: flex;
   justify-content: flex-start;

packages/openneuro-app/src/scripts/dataset/files/file-tree.tsx

@@ -17,6 +17,7 @@ interface FileTreeProps {
   files: DatasetFile[]
   editMode: boolean
   defaultExpanded: boolean
+  /* eslint-disable-next-line @typescript-eslint/no-explicit-any */
   datasetPermissions: any
   toggleFileToDelete: ({ id, path, filename }) => void
   isFileToBeDeleted: (id: string) => boolean

packages/openneuro-app/src/scripts/dataset/files/files.tsx

@@ -39,7 +39,9 @@ interface FilesProps {
   datasetName: string
   files: DatasetFile[]
   editMode: boolean
+  /* eslint-disable-next-line @typescript-eslint/no-explicit-any */
   datasetPermissions: any
+  /* eslint-disable-next-line @typescript-eslint/no-explicit-any */
   summary: any
 }
 

packages/openneuro-app/src/scripts/dataset/files/viewers/file-viewer-nifti.tsx

@@ -17,17 +17,19 @@ const FileViewerNifti = ({
         limitFrames4D: 5,
       },
     ]
-    const nv = new Niivue({ dragAndDropEnabled: false })
+    const nv = new Niivue({
+      dragAndDropEnabled: false,
+    }) /* eslint-disable-next-line @typescript-eslint/no-explicit-any */
     ;(window as any).niivue = nv
     nv.attachToCanvas(canvas.current)
     nv.loadVolumes(volumeList) // press the "v" key to cycle through views (axial, coronal, sagittal, 3D, etc.)
     nv.graph.autoSizeMultiplanar = true // use autosizing
     nv.opts.multiplanarForceRender = true // ensure that we draw the time series graph in the tile usually reserved for the 3D render
     nv.graph.normalizeValues = false // use raw data values on y-axis
     nv.graph.opacity = 1.0 // show the graph
-    // Notes: 
+    // Notes:
     // 1.   If an image only has one volume, the timeseries graph will not be visible.
-    //      The 3D render will be placed in the graph tile instead. 
+    //      The 3D render will be placed in the graph tile instead.
     // 2.   Users can navigate volumes forward and backward in the series using the left and right arrow keys on desktop devices
     // 3.   On touch screens, users can tap on the timeseries graph to jump to a volume index
     // 4.   Users can load all volumes by clicking on the "..." displayed on the timeseries graph