refactor(app): Decouple React client from @openneuro/client #3194
+342
−102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nellh
force-pushed
the
app-decouple-client
branch
from
9e65900 to
aea148c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3194 +/- ##
==========================================
- Coverage 44.45% 44.26% -0.19%
==========================================
Files 592 594 +2
Lines 37861 38104 +243
Branches 1131 1133 +2
==========================================
+ Hits 16830 16868 +38
- Misses 20831 21034 +203
- Partials 200 202 +2 ☔ View full report in Codecov by Sentry. |
The client will no longer be needed with the move to deno CLI and this allows for frontend specific client configuration. Fixes error handling not bubbling up properly across the React app.
nellh
force-pushed
the
app-decouple-client
branch
from
aea148c to
9cd288d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The client package will no longer be needed with the move to deno CLI and this allows for frontend specific client configuration.
Fixes error handling not bubbling up properly across the React app. Otherwise no functional changes.