User routes #3242
Merged
User routes #3242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3242 +/- ##
==========================================
+ Coverage 45.68% 46.68% +1.00%
==========================================
Files 595 609 +14
Lines 38015 38698 +683
Branches 1171 1225 +54
==========================================
+ Hits 17366 18066 +700
+ Misses 20452 20437 -15
+ Partials 197 195 -2 ☔ View full report in Codecov by Sentry. |
nellh
reviewed
Dec 2, 2024
Contributor
nellh
left a comment
nellh
left a comment
There was a problem hiding this comment.
Looks like this is on the right track. Added some suggestions but it's mostly minor fixes.
packages/openneuro-app/src/scripts/users/user-account-container.tsx
Outdated
Show resolved
Hide resolved
…ser props in user-container
Contributor
Author
ok, lint/ts issues have been resolved. |
nellh
approved these changes
Dec 18, 2024
Contributor
nellh
left a comment
nellh
left a comment
There was a problem hiding this comment.
Approved with minor changes for the test filenames.
packages/openneuro-app/src/scripts/users/__tests__/user-account-view.tsx
Outdated
Show resolved
Hide resolved
packages/openneuro-app/src/scripts/users/__tests__/user-account-view.tsx
Outdated
Show resolved
Hide resolved
packages/openneuro-app/src/scripts/users/__tests__/user-account-view.tsx
Outdated
Show resolved
Hide resolved
nellh
requested changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.