Skip to content

Conversation

@nellh
Copy link
Contributor

@nellh nellh commented Aug 11, 2025

This adds a dataset:worker scope to the API. Allows the worker to make automated requests to the API with the scope of updating a single dataset.

This also corrects an issue where special tokens that never contain emails would occasionally throw an error where the request should have succeeded by checking the email state after the special cases.

Don't require email addresses for special tokens
@nellh nellh requested a review from thinknoack August 11, 2025 16:32
@codecov
Copy link

codecov bot commented Aug 11, 2025

Codecov Report

❌ Patch coverage is 12.50000% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.42%. Comparing base (093bcc8) to head (596b6f7).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...enneuro-server/src/libs/authentication/passport.ts 0.00% 8 Missing ⚠️
...ckages/openneuro-server/src/graphql/permissions.ts 25.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3533      +/-   ##
==========================================
- Coverage   48.44%   48.42%   -0.02%     
==========================================
  Files         596      596              
  Lines       42232    42245      +13     
  Branches     1391     1391              
==========================================
  Hits        20459    20459              
- Misses      21604    21617      +13     
  Partials      169      169              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nellh nellh merged commit a0ae008 into master Aug 11, 2025
13 of 15 checks passed
@nellh nellh deleted the worker-scope-tokens branch August 11, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants