Skip to content

feat(server): Allow worker scopes for tokens #3533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2025
Merged

feat(server): Allow worker scopes for tokens #3533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions packages/openneuro-server/src/graphql/permissions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,13 +138,18 @@ export const checkDatasetWrite = async (
// Quick path for anonymous writes
throw new Error(state.errorMessage)
}
if (userId && !(userInfo.email)) {
throw new Error("Connect an email to make contributions to OpenNeuro.")
}
if (userId && userInfo.admin) {
// Always allow site admins
return true
}
// Allow worker scoped tokens to make admin actions on specific datasets
if (userId && userInfo?.worker && datasetId === userInfo?.dataset) {
return true
}
if (userId && !(userInfo.email)) {
throw new Error("Connect an email to make contributions to OpenNeuro.")
}
// Finally check the permissions model if other checks have not returned
const permission = await Permission.findOne({ datasetId, userId }).exec()
if (checkPermissionLevel(permission, state)) {
return true
Expand Down
8 changes: 8 additions & 0 deletions packages/openneuro-server/src/libs/authentication/passport.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,14 @@ export const setupPassportAuth = () => {
(jwt, done) => {
if (jwt.scopes?.includes("dataset:indexing")) {
done(null, { admin: false, blocked: false, indexer: true })
} else if (jwt.scopes?.includes("dataset:worker")) {
done(null, {
id: jwt.sub,
admin: false,
blocked: false,
worker: true,
dataset: jwt.dataset,
})
} else if (jwt.scopes?.includes("dataset:reviewer")) {
done(null, {
admin: false,
Expand Down