Skip to content

Conversation

@nellh
Copy link
Contributor

@nellh nellh commented Aug 11, 2025

This adds a task that runs after HEAD is updated or a tag is created to verify local or remote annex fsck state.

There is a 7 day delay before the same objects will be rechecked, any changed objects are always rechecked - the delay just limits how often we recheck an already validated file. This delay may need to be adjusted depending on the resource usage in production.

One included major change required is the move coroutines for commits.

@codecov
Copy link

codecov bot commented Aug 11, 2025

Codecov Report

❌ Patch coverage is 78.49462% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.48%. Comparing base (093bcc8) to head (c5fb5ae).
⚠️ Report is 17 commits behind head on master.

Files with missing lines Patch % Lines
services/datalad/datalad_service/tasks/fsck.py 68.51% 17 Missing ⚠️
...ervices/datalad/datalad_service/handlers/upload.py 0.00% 2 Missing ⚠️
services/datalad/datalad_service/handlers/files.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3534      +/-   ##
==========================================
+ Coverage   48.44%   48.48%   +0.04%     
==========================================
  Files         596      598       +2     
  Lines       42232    42298      +66     
  Branches     1391     1391              
==========================================
+ Hits        20459    20508      +49     
- Misses      21604    21621      +17     
  Partials      169      169              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nellh nellh requested a review from thinknoack August 12, 2025 17:17
Copy link
Contributor

@thinknoack thinknoack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests pass and fsck checks run after update

@nellh nellh merged commit 37dc4de into master Aug 12, 2025
15 checks passed
@nellh nellh deleted the annex-fsck-tasks branch August 12, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants