Skip to content

Conversation

@nellh
Copy link
Contributor

@nellh nellh commented Aug 11, 2025

Fixes #3459 and improves text for the error page.

@codecov
Copy link

codecov bot commented Aug 11, 2025

Codecov Report

❌ Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.41%. Comparing base (a0ae008) to head (66c68d2).
⚠️ Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
...openneuro-app/src/scripts/errors/orcid/general.jsx 0.00% 12 Missing ⚠️
...es/openneuro-app/src/scripts/errors/errorRoute.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3536      +/-   ##
==========================================
- Coverage   48.42%   48.41%   -0.02%     
==========================================
  Files         596      596              
  Lines       42245    42258      +13     
  Branches     1391     1391              
==========================================
  Hits        20459    20459              
- Misses      21617    21630      +13     
  Partials      169      169              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nellh nellh merged commit f2309ce into master Aug 12, 2025
13 of 15 checks passed
@nellh nellh deleted the 3459-orcid-fix branch August 12, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ORCID unhandled auth error displays 404 page

2 participants