refactor(cli): Recheck annexed object contents added in previous upload runs #3563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solves a case where the CLI could be interrupted and fail to retransfer keys it created previously. Instead of tracking the new annex keys as they are generated per run, we read all annex keys from HEAD and recheck them against the remote.
nellh
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3563 +/- ##
==========================================
- Coverage 49.00% 48.94% -0.07%
==========================================
Files 612 612
Lines 43542 43598 +56
Branches 1477 1477
==========================================
Hits 21338 21338
- Misses 22034 22090 +56
Partials 170 170 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
thinknoack
approved these changes
Sep 3, 2025
Contributor
thinknoack
left a comment
thinknoack
left a comment
There was a problem hiding this comment.
Reviewed the removal of annexed files, push of files to same dataset.
transferred the key and didn't make new changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves a case where the command line tools could be interrupted during upload and fail to retransfer keys it created previously. See #3561
Instead of tracking the new annex keys as they are generated per run, we read all annex keys from HEAD and recheck them against the remote.
Reading the existing keys is also necessary to avoid rechecking MD5E hashes for #3562.