Skip to content

Conversation

@thinknoack
Copy link
Contributor

@thinknoack thinknoack commented Oct 7, 2025

this PR is mostly about cleaning up and refactoring the code that was previously merged into Master, before Integrating the mutations to the UI

A few things were not working and there were different status for diff event types.

  • refactored datasetEvents to handle resolutionStatus consistently
  • added proper handling for contributorRequest, contributorResponse, and contributorCitation events
  • processContributorRequest & processContributorCitation both use id lookup, not _id
  • updated response creation and datacite updates for accepted requests
  • cleaned up type guards and event mapping logic for better clarity

@thinknoack thinknoack requested a review from nellh October 7, 2025 21:40
@codecov
Copy link

codecov bot commented Oct 7, 2025

Codecov Report

❌ Patch coverage is 26.40000% with 184 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.96%. Comparing base (df90371) to head (80141e4).
⚠️ Report is 31 commits behind head on master.

Files with missing lines Patch % Lines
...euro-server/src/graphql/resolvers/datasetEvents.ts 0.84% 118 Missing ⚠️
...ges/openneuro-app/src/scripts/types/event-types.ts 0.00% 24 Missing ⚠️
...ipts/users/user-notification-accordion-actions.tsx 0.00% 17 Missing ⚠️
...cripts/users/user-notifications-accordion-body.tsx 0.00% 10 Missing ⚠️
...kages/openneuro-server/src/utils/datacite-utils.ts 86.79% 7 Missing ⚠️
.../src/scripts/users/user-notification-accordion.tsx 0.00% 6 Missing ⚠️
.../scripts/dataset/components/dataset-event-item.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3595      +/-   ##
==========================================
+ Coverage   42.93%   42.96%   +0.02%     
==========================================
  Files         633      633              
  Lines       33142    33244     +102     
  Branches     1479     1482       +3     
==========================================
+ Hits        14231    14283      +52     
- Misses      18772    18822      +50     
  Partials      139      139              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@thinknoack thinknoack changed the title App/contributor list display Api/contributor events Oct 13, 2025
@nellh nellh merged commit 8f5d187 into master Oct 23, 2025
14 of 15 checks passed
@nellh nellh deleted the app/contributor-list-display branch October 23, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants