Skip to content

Conversation

@thinknoack
Copy link
Contributor

@thinknoack thinknoack commented Nov 5, 2025

refactors contributor events to be approved during the create event and only send a notification that a user has been added, instead of requiring approval.

users resolver not allows for searching of users by non admin, only admin can see email, admin, and blocked fields

adds a hasEdit check for dataset editing of the contributor list/form

…orEvent and send a notice in the processContributorEvent
…e non-null values for email, blocked, and admin fields
@thinknoack thinknoack marked this pull request as draft November 5, 2025 21:02
@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

❌ Patch coverage is 29.11392% with 56 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.09%. Comparing base (c25c7ef) to head (62dd1b1).
⚠️ Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
...euro-server/src/graphql/resolvers/datasetEvents.ts 0.00% 28 Missing ⚠️
...app/src/scripts/contributors/contributors-list.tsx 40.00% 18 Missing ⚠️
...otifications/user-notifications-accordion-body.tsx 0.00% 7 Missing ⚠️
...tifications/user-notification-accordion-header.tsx 0.00% 2 Missing ⚠️
...ges/openneuro-app/src/scripts/types/event-types.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3621      +/-   ##
==========================================
+ Coverage   43.05%   43.09%   +0.03%     
==========================================
  Files         635      635              
  Lines       33674    33715      +41     
  Branches     1516     1515       -1     
==========================================
+ Hits        14498    14528      +30     
- Misses      19037    19048      +11     
  Partials      139      139              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@thinknoack thinknoack requested a review from nellh November 6, 2025 20:59
@thinknoack thinknoack marked this pull request as ready for review November 6, 2025 20:59
@nellh nellh changed the title WIP Refactor/contributor citation events Refactor/contributor citation events Nov 6, 2025
@nellh nellh merged commit 02dc5d2 into master Nov 6, 2025
14 of 15 checks passed
@nellh nellh deleted the refactor/contributor-citation-events branch November 6, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants