From 8421df4529446e449b19987e7d623344c0210a4d Mon Sep 17 00:00:00 2001 From: Gregory Noack Date: Fri, 7 Nov 2025 14:41:57 -0800 Subject: [PATCH 1/2] update sentry to only log if dataset has datacite --- packages/openneuro-server/src/datalad/contributors.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/openneuro-server/src/datalad/contributors.ts b/packages/openneuro-server/src/datalad/contributors.ts index e736d7fea..68ad56e1a 100644 --- a/packages/openneuro-server/src/datalad/contributors.ts +++ b/packages/openneuro-server/src/datalad/contributors.ts @@ -67,7 +67,8 @@ export const contributors = async ( } // --- Dataset type but no contributors --- - if (resourceType === "Dataset") { + // Only log if a Datacite file actually exists + if (dataciteData && resourceType === "Dataset") { Sentry.captureMessage( `Datacite file for ${datasetId}:${revisionShort} is Dataset type but provided no contributors.`, ) From 3ccb98eddcd910d74ae4f8782a8ad27b89cc20d9 Mon Sep 17 00:00:00 2001 From: Gregory Noack Date: Fri, 7 Nov 2025 14:51:33 -0800 Subject: [PATCH 2/2] update condition to ensures the file is real and has metadata --- packages/openneuro-server/src/datalad/contributors.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/openneuro-server/src/datalad/contributors.ts b/packages/openneuro-server/src/datalad/contributors.ts index 68ad56e1a..53b9d1057 100644 --- a/packages/openneuro-server/src/datalad/contributors.ts +++ b/packages/openneuro-server/src/datalad/contributors.ts @@ -68,7 +68,11 @@ export const contributors = async ( // --- Dataset type but no contributors --- // Only log if a Datacite file actually exists - if (dataciteData && resourceType === "Dataset") { + if ( + dataciteData?.data?.attributes && + resourceType === "Dataset" && + !attributes?.contributors?.length + ) { Sentry.captureMessage( `Datacite file for ${datasetId}:${revisionShort} is Dataset type but provided no contributors.`, )