Skip to content

update sentry to only log if dataset has datacite #3630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 7, 2025
Merged

update sentry to only log if dataset has datacite #3630

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8421df4
update sentry to only log if dataset has datacite
thinknoack Nov 7, 2025
3ccb98e
update condition to ensures the file is real and has metadata
thinknoack Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/openneuro-server/src/datalad/contributors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,12 @@ export const contributors = async (
}

// --- Dataset type but no contributors ---
if (resourceType === "Dataset") {
// Only log if a Datacite file actually exists
if (
dataciteData?.data?.attributes &&
resourceType === "Dataset" &&
!attributes?.contributors?.length
) {
Sentry.captureMessage(
`Datacite file for ${datasetId}:${revisionShort} is Dataset type but provided no contributors.`,
)
Expand Down