-
Notifications
You must be signed in to change notification settings - Fork 42
Fixes for backup remote exports and annex drop #3639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
nellh
commented
Nov 11, 2025
- Block less often with async coroutines for S3 export tasks
- Fix an issue with credentials that would cause drop to fail depending on how the s3 remote was configured
- Fix a bug with an extra argument for the fsck / drop pipeline
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3639 +/- ##
=======================================
Coverage 42.98% 42.99%
=======================================
Files 635 635
Lines 33809 33817 +8
Branches 1518 1518
=======================================
+ Hits 14534 14538 +4
- Misses 19136 19140 +4
Partials 139 139 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| if env: | ||
| process = await asyncio.create_subprocess_exec( | ||
| *command, | ||
| cwd=dataset_path, | ||
| env=env, | ||
| stdout=asyncio.subprocess.PIPE, | ||
| stderr=asyncio.subprocess.PIPE, | ||
| ) | ||
| else: | ||
| process = await asyncio.create_subprocess_exec( | ||
| *command, | ||
| cwd=dataset_path, | ||
| stdout=asyncio.subprocess.PIPE, | ||
| stderr=asyncio.subprocess.PIPE, | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default value of env is already None: https://docs.python.org/3/library/subprocess.html#subprocess.Popen
| if env: | |
| process = await asyncio.create_subprocess_exec( | |
| *command, | |
| cwd=dataset_path, | |
| env=env, | |
| stdout=asyncio.subprocess.PIPE, | |
| stderr=asyncio.subprocess.PIPE, | |
| ) | |
| else: | |
| process = await asyncio.create_subprocess_exec( | |
| *command, | |
| cwd=dataset_path, | |
| stdout=asyncio.subprocess.PIPE, | |
| stderr=asyncio.subprocess.PIPE, | |
| ) | |
| process = await asyncio.create_subprocess_exec( | |
| *command, | |
| cwd=dataset_path, | |
| env=env, | |
| stdout=asyncio.subprocess.PIPE, | |
| stderr=asyncio.subprocess.PIPE, | |
| ) |
Did you find this made a difference in practice?