feat(worker): Presign S3 URLs for client access to private datasets #3645
+93
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3645 +/- ##
==========================================
+ Coverage 42.92% 42.96% +0.04%
==========================================
Files 635 636 +1
Lines 33849 33871 +22
Branches 1515 1515
==========================================
+ Hits 14528 14552 +24
+ Misses 19182 19180 -2
Partials 139 139 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches to using presigned URLs for any files in OpenNeuro's S3 buckets. Anonymous requests are still used for any other S3 buckets. A client can now browse a private dataset with remote files that are not publicly accessible as long as the user has dataset read permissions on OpenNeuro.
Introduces a shared boto3 session which avoids reconfiguring boto3 frequently when signing large numbers of files.