Skip to content

fix(worker): Add logging and enable private tag exports during drop task #3650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2025
Merged

fix(worker): Add logging and enable private tag exports during drop task #3650

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions services/datalad/datalad_service/tasks/publish.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,13 +96,24 @@ async def export_backup_and_drop(dataset_path):
"""
Export dataset to S3 backup, verify s3-PUBLIC, and drop local data.
"""
dataset_id = os.path.basename(dataset_path)
public_dataset = is_public_dataset(dataset_id)
repo = pygit2.Repository(dataset_path)
update_s3_sibling(dataset_path)
tags = sorted(git_tag(repo), key=lambda tag: tag.name)
if tags:
await s3_backup_push(dataset_path)
for tag in tags:
logger.info(f'Exporting/dropping tag {dataset_id}@{tag.name}')
# Private datasets need to export each tag for this step
if not public_dataset:
await s3_export(dataset_path, get_s3_remote(), tag.name)
await fsck_and_drop(dataset_path, tag.name)
logger.info(f'Exporting/dropping tag {dataset_id}@{tag.name} complete')
if not public_dataset:
logger.info(f'Setting access tag for {dataset_id}')
await set_s3_access_tag(dataset_id, 'private')
logger.info(f'{dataset_id} export_backup_and_drop complete')


@broker.task
Expand Down