fix: Smudge non-annexed files, ensuring eol enforcement #3664
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch should avoid further pollution of repositories with CRLF end-of-line markers. What seems to be happening is that
git annex addensures that we efficiently hash files, but does not ensure that non-annexed files pass through the smudge filters. Adding a secondadd_allshould be a cheap fix for this.I also skip empty commits.
With these two changes, I think the following would fix old datasets:
git_commit(repo, '.', message='[OpenNeuro] Apply smudge filters'). I'm not sure if this is something that should be put onto the task queue?Fixes: #3257
Fixes: #3531