Skip to content

Conversation

@effigies
Copy link
Contributor

@effigies effigies commented Nov 24, 2025

This patch should avoid further pollution of repositories with CRLF end-of-line markers. What seems to be happening is that git annex add ensures that we efficiently hash files, but does not ensure that non-annexed files pass through the smudge filters. Adding a second add_all should be a cheap fix for this.

I also skip empty commits.

With these two changes, I think the following would fix old datasets: git_commit(repo, '.', message='[OpenNeuro] Apply smudge filters'). I'm not sure if this is something that should be put onto the task queue?

Fixes: #3257
Fixes: #3531

@effigies effigies force-pushed the fix/commit-linefeed branch from 8bc43c1 to 937d9ca Compare November 24, 2025 19:39
@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.02%. Comparing base (380c6ee) to head (937d9ca).
⚠️ Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3664      +/-   ##
==========================================
+ Coverage   42.99%   45.02%   +2.02%     
==========================================
  Files         636      636              
  Lines       33912    33922      +10     
  Branches     1516     1595      +79     
==========================================
+ Hits        14582    15274     +692     
+ Misses      19191    18519     -672     
+ Partials      139      129      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nellh nellh merged commit 07b085c into OpenNeuroOrg:master Dec 1, 2025
15 checks passed
@effigies effigies deleted the fix/commit-linefeed branch December 1, 2025 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants