Improve consistency in georeferencing setup

After calling Georeferencing::setProjectedRefPoint(..., false, false),
consistently configure scaling and rotation explicitly. In most cases,
this means simply preserving the current values of combined scale
factor and grivation (which affect the transformation to paper
coordinates directly), causing calculated updates to auxiliary scale
factor and declination.
Given that transformation is preserved, there shall be no visible
effect. However, the Georeferencing objects are put into a consistent
state with regard to the scaling and rotation variables, similar to
what is otherwise achieved by calling setProjectedRefPoint(...).
This relevant at least where Georeferencing objects are saved/loaded
as member of template configuration etc.

Author: dg0yt

src/fileformats/ocd_georef_fields.cpp

@@ -852,7 +852,7 @@ void OcdGeorefFields::setupGeoref(Georeferencing& georef,
 
 	QPointF proj_ref_point(x, y);
 	georef.setProjectedRefPoint(proj_ref_point, false, false);
-	
+	georef.setCombinedScaleFactor(1.0);
 	georef.setGrivation(qIsFinite(a) ? a : 0);
 }
 

src/fileformats/xml_file_format.cpp

@@ -594,6 +594,8 @@ bool XMLFileImporter::importImplementation()
 			auto ref_point = MapCoordF { georef.getMapRefPoint() };
 			auto new_projected = georef.toProjectedCoords(ref_point + offset_f);
 			georef.setProjectedRefPoint(new_projected, false, false);
+			georef.setCombinedScaleFactor(georef.getCombinedScaleFactor()); // keep combined scale factor
+			georef.setGrivation(georef.getGrivation());  // keep grivation, update declination
 			map->setGeoreferencing(georef);
 		}
 	}

src/gdal/ogr_file_format.cpp

@@ -851,6 +851,8 @@ bool OgrFileImport::importImplementation()
 			auto ref_point = MapCoordF { georef.getMapRefPoint() };
 			auto new_projected = georef.toProjectedCoords(ref_point + offset_f);
 			georef.setProjectedRefPoint(new_projected, false, false);
+			georef.setCombinedScaleFactor(georef.getCombinedScaleFactor()); // keep combined scale factor
+			georef.setGrivation(georef.getGrivation());  // keep grivation, update declination
 			map->setGeoreferencing(georef);
 		}
 	}
@@ -971,6 +973,7 @@ ogr::unique_srs OgrFileImport::importGeoreferencing(OGRDataSourceH data_source)
 		                             .arg(latitude, 0, 'f')
 		                             .arg(longitude, 0, 'f') );
 		ortho_georef.setProjectedRefPoint({}, false, false);
+		ortho_georef.setCombinedScaleFactor(1.0);
 		ortho_georef.setDeclination(map->getGeoreferencing().getDeclination());
 		map->setGeoreferencing(ortho_georef);
 		return srsFromMap();

src/gdal/ogr_template.cpp

@@ -194,6 +194,8 @@ std::unique_ptr<Georeferencing> OgrTemplate::makeOrthographicGeoreferencing(cons
 		                             QString::fromLatin1("+proj=ortho +datum=WGS84 +ellps=WGS84 +units=m +lat_0=%1 +lon_0=%2 +no_defs")
 		                             .arg(center.latitude()).arg(center.longitude()));
 		georef->setProjectedRefPoint({}, false, false);
+		georef->setCombinedScaleFactor(1.0);
+		georef->setGrivation(0.0);
 	}
 	else
 	{
@@ -368,6 +370,8 @@ try
 					explicit_georef->setScaleDenominator(int(map_georef.getScaleDenominator()));
 					explicit_georef->setProjectedCRS(QString{}, projected_crs_spec);
 					explicit_georef->setProjectedRefPoint({}, false, false);
+					explicit_georef->setCombinedScaleFactor(1.0);
+					explicit_georef->setGrivation(0.0);
 				}
 			}
 		}

src/templates/template_image.cpp

@@ -235,6 +235,8 @@ bool TemplateImage::postLoadConfiguration(QWidget* dialog_parent, bool& out_cent
 				calculateGeoreferencing();
 				auto const center_pixel = MapCoordF(0.5 * (image.width() - 1), 0.5 * (image.height() - 1));
 				initial_georef.setProjectedRefPoint(georef->toProjectedCoords(center_pixel));
+				initial_georef.setCombinedScaleFactor(1.0);
+				initial_georef.setGrivation(0.0);
 			}
 
 			GeoreferencingDialog dialog(dialog_parent, map, &initial_georef, false);

src/templates/template_track.cpp

@@ -609,6 +609,8 @@ void TemplateTrack::applyProjectedCrsSpec()
 	georef.setScaleDenominator(int(map->getScaleDenominator()));
 	georef.setProjectedCRS(QString{}, projected_crs_spec);
 	georef.setProjectedRefPoint({});
+	georef.setCombinedScaleFactor(1.0);
+	georef.setGrivation(0.0);
 	track.changeMapGeoreferencing(georef);
 }