Fix warnings Handle nulls, update process handling, and add config UseRidGraph

Author: TommyKolodziejczyk

src/IntelOrca.OpenLauncher.Core/Build.cs

@@ -33,16 +33,20 @@ public Version? ParsedVersion
 
         public override string ToString() => Version;
 
-        public int CompareTo(Build other)
+        public int CompareTo(Build? other)
         {
+            ArgumentNullException.ThrowIfNull(other);
+
             var a = PublishedAt;
             var b = other.PublishedAt;
+
             if (a is null && b is null)
                 return 0;
             if (a is null)
                 return 1;
             if (b is null)
                 return -1;
+
             return b.Value.CompareTo(a.Value);
         }
     }

src/IntelOrca.OpenLauncher.Core/BuildAsset.cs

@@ -117,8 +117,13 @@ public class BuildAssetComparer : IComparer<BuildAsset>
 
         public static BuildAssetComparer Default = new BuildAssetComparer();
 
-        public int Compare(BuildAsset x, BuildAsset y)
+        public int Compare(BuildAsset? x, BuildAsset? y)
         {
+            if (x == null || y == null)
+            {
+                throw new ArgumentNullException("BuildAsset objects cannot be null");
+            }
+
             if (x.Platform == y.Platform)
             {
                 if (x.Arch != y.Arch)

src/IntelOrca.OpenLauncher.Core/InstallService.cs

@@ -7,6 +7,7 @@
 using System.Text;
 using System.Threading;
 using System.Threading.Tasks;
+using System.Xml.Linq;
 
 namespace IntelOrca.OpenLauncher.Core
 {
@@ -73,12 +74,15 @@ public Task Launch()
                 {
                     RedirectStandardError = true
                 };
-                var process = Process.Start(psi);
+
+                var process = Process.Start(psi) ?? throw new InvalidOperationException($"Failed to start process '{psi}'");
+
                 var outputBuilder = new StringBuilder();
                 var sw = Stopwatch.StartNew();
+
                 while (sw.ElapsedMilliseconds < 2000)
                 {
-                    var s = process.StandardError.ReadToEnd();
+                    string? s = process.StandardError.ReadToEnd();
                     if (s != null)
                         outputBuilder.Append(s);
 

src/IntelOrca.OpenLauncher.Core/IntelOrca.OpenLauncher.Core.csproj

@@ -6,6 +6,5 @@
   <ItemGroup>
     <PackageReference Include="Octokit" Version="0.51.0" />
     <PackageReference Include="System.Collections.Immutable" Version="8.0.0" />
-    <PackageReference Include="System.Text.Json" Version="8.0.4" />
   </ItemGroup>
 </Project>

src/IntelOrca.OpenLauncher.Core/Shell.cs

@@ -25,7 +25,7 @@ public int RunProcess(string name, params string[] args)
             {
                 psi.ArgumentList.Add(arg);
             }
-            var p = Process.Start(psi);
+            var p = Process.Start(psi) ?? throw new InvalidOperationException($"Failed to start process '{name}'");
             p.WaitForExit();
             return p.ExitCode;
         }

src/openlauncher/openlauncher.csproj

@@ -18,6 +18,9 @@
     <IncludeNativeLibrariesForSelfExtract>true</IncludeNativeLibrariesForSelfExtract>
     <ApplicationIcon>resources\logo.ico</ApplicationIcon>
   </PropertyGroup>
+  <ItemGroup>
+  <RuntimeHostConfigurationOption Include="System.Runtime.Loader.UseRidGraph" Value="true" />
+</ItemGroup>
   <ItemGroup>
     <Compile Update="Properties\Resources.Designer.cs">
       <DesignTime>True</DesignTime>