refactor: 🔥 Remove avg. cycle time from dahsboard

Author: jhw-db

popupsim/frontend/dashboard.py

@@ -161,24 +161,22 @@ def _render_comparison_view(base_path: Path, selected_scenarios: list[str]) -> N
         metrics = data.get('metrics', {})
         wagon_journey = data.get('wagon_journey')
 
-        # Calculate cycle time
-        avg_cycle_time = 0
+        # Get total wagon count
+        total_wagons = 0
         if wagon_journey is not None and not wagon_journey.empty:
-            completed = wagon_journey[wagon_journey['status'] == 'COMPLETED']
-            if not completed.empty:
-                cycle_times = completed.groupby('wagon_id')['timestamp'].agg(['min', 'max'])
-                cycle_times['duration'] = cycle_times['max'] - cycle_times['min']
-                avg_cycle_time = cycle_times['duration'].mean()
+            total_wagons = wagon_journey['wagon_id'].nunique()
+
+        # Calculate rejection percentage based on total wagons
+        rejection_pct = (metrics.get('wagons_rejected', 0) / total_wagons * 100) if total_wagons > 0 else 0
 
         comparison_data.append(
             {
                 'Scenario': scenario_name,
                 'Trains': metrics.get('trains_arrived', 0),
-                'Wagons': metrics.get('wagons_arrived', 0),
+                'Wagons': total_wagons,
                 'Rejected': metrics.get('wagons_rejected', 0),
-                'Rejection %': f'{(metrics.get("wagons_rejected", 0) / metrics.get("wagons_arrived", 1) * 100):.1f}',
+                'Rejection %': f'{rejection_pct:.1f}',
                 'Retrofits': metrics.get('retrofits_completed', 0),
-                'Avg Cycle Time (min)': f'{avg_cycle_time:.1f}',
             }
         )
 
@@ -190,7 +188,7 @@ def _render_comparison_view(base_path: Path, selected_scenarios: list[str]) -> N
         baseline = comparison_df.iloc[0]
         compare = comparison_df.iloc[1]
 
-        col1, col2, col3, col4 = st.columns(4)
+        col1, col2, col3 = st.columns(3)
         with col1:
             delta_retrofits = compare['Retrofits'] - baseline['Retrofits']
             delta_pct = (delta_retrofits / baseline['Retrofits'] * 100) if baseline['Retrofits'] > 0 else 0
@@ -206,12 +204,6 @@ def _render_comparison_view(base_path: Path, selected_scenarios: list[str]) -> N
             delta_rej_rate = compare_rej_rate - baseline_rej_rate
             st.metric('Rejection Rate', f'{compare_rej_rate:.1f}%', f'{delta_rej_rate:+.1f}%', delta_color='inverse')
 
-        with col4:
-            baseline_cycle = float(baseline['Avg Cycle Time (min)'])
-            compare_cycle = float(compare['Avg Cycle Time (min)'])
-            delta_cycle = compare_cycle - baseline_cycle
-            st.metric('Avg Cycle Time', f'{compare_cycle:.1f} min', f'{delta_cycle:+.1f} min', delta_color='inverse')
-
     st.dataframe(comparison_df, use_container_width=True, hide_index=True)
 
     if st.button('📥 Export KPI Comparison CSV'):
@@ -295,29 +287,6 @@ def _render_comparison_view(base_path: Path, selected_scenarios: list[str]) -> N
             },
         )
 
-    with col2:
-        cycle_times = [float(x) for x in comparison_df['Avg Cycle Time (min)']]
-        fig = go.Figure(
-            data=[
-                go.Bar(
-                    x=comparison_df['Scenario'],
-                    y=cycle_times,
-                    marker_color='#9b59b6',
-                    text=[f'{x:.1f}' for x in cycle_times],
-                    textposition='auto',
-                )
-            ]
-        )
-        fig.update_layout(title='Average Cycle Time', xaxis_title='Scenario', yaxis_title='Minutes', height=300)
-        st.plotly_chart(
-            fig,
-            use_container_width=True,
-            config={
-                'displayModeBar': True,
-                'toImageButtonOptions': {'format': 'png', 'filename': 'comparison_cycle_time'},
-            },
-        )
-
     st.markdown('---')
 
     # Workshop comparison