ui-chart: fix cases where spaceOrigin != 0

Signed-off-by: Valentin Chanas <[email protected]>
Signed-off-by: Achrafmohye <[email protected]>

Author: anisometropie

storybook/stories/ui-charts/spaceTimeChart/rectangle-zoom.stories.tsx

@@ -8,6 +8,7 @@ import {
   type Point,
   type PathData,
   type OperationalPoint,
+  type SpaceScale,
 } from '@osrd-project/ui-charts';
 import { Button, Slider } from '@osrd-project/ui-core';
 import type { Meta } from '@storybook/react';
@@ -93,9 +94,8 @@ const RectangleZoomWrapper = ({
 
   const timeOrigin = +new Date('2024-04-02T00:00:00');
   const timeScale = zoomValueToTimeScale(state.timeZoomValue);
-  const spaceScale = [
+  const spaceScale: SpaceScale[] = [
     {
-      from: -100000,
       to: 100000,
       coefficient: zoomValueToSpaceScale(state.spaceZoomValue), // meter/px
     },

storybook/stories/ui-charts/trackOccupancyDiagram/rendering.stories.tsx

@@ -152,7 +152,7 @@ const TrackOccupancyDiagram = ({
     const getSpacePixel = getSpaceToPixel(spacePixelOffset, spaceScaleTree);
     const getPoint = getDataToPoint(getTimePixel, getSpacePixel, timeAxis, spaceAxis);
     const getTime = getPixelToTime(timeOrigin, timePixelOffset, timeScale);
-    const getSpace = getPixelToSpace(spaceOrigin, spacePixelOffset, spaceScaleTree);
+    const getSpace = getPixelToSpace(spacePixelOffset, spaceScaleTree);
     const getData = getPointToData(getTime, getSpace, timeAxis, spaceAxis);
 
     const pickingElements: PickingElement[] = [];

ui-charts/src/spaceTimeChart/components/SpaceTimeChart.tsx

@@ -115,7 +115,7 @@ export const SpaceTimeChart = (props: SpaceTimeChartProps) => {
     const getSpacePixel = getSpaceToPixel(spacePixelOffset, spaceScaleTree);
     const getPoint = getDataToPoint(getTimePixel, getSpacePixel, timeAxis, spaceAxis);
     const getTime = getPixelToTime(timeOrigin, timePixelOffset, timeScale);
-    const getSpace = getPixelToSpace(spaceOrigin, spacePixelOffset, spaceScaleTree);
+    const getSpace = getPixelToSpace(spacePixelOffset, spaceScaleTree);
     const getData = getPointToData(getTime, getSpace, timeAxis, spaceAxis);
 
     const pickingElements: PickingElement[] = [];

ui-charts/src/spaceTimeChart/utils/scales.ts

@@ -182,7 +182,6 @@ export function getSpaceToPixel(
 }
 
 export function getPixelToSpace(
-  spaceOrigin: number,
   pixelOffset: number,
   binaryTree: NormalizedScaleTree
 ): PixelToSpace {
@@ -191,7 +190,7 @@ export function getPixelToSpace(
       spacePixel - pixelOffset,
       binaryTree
     );
-    return spaceOrigin + from + (spacePixel - pixelOffset - pixelFrom) * coefficient;
+    return from + (spacePixel - pixelOffset - pixelFrom) * coefficient;
   };
 }