front: rename OperationalPointIdentifier to OperationalPointReference

Author: younesschrifi

front/public/locales/en/operational-studies.json

@@ -152,7 +152,7 @@
       "project": "Project",
       "restore": "Restore to template"
     },
-    "operationalPointIdentifier": "Operational point identifier",
+    "OperationalPointReference": "Operational point reference",
     "pacedTrainAndTrainCount": "$t(main.pacedTrainCount, { 'count': {{pacedTrainCount}}, 'totalCount': {{totalPacedTrainCount}} }), $t(main.trainCount, { 'count': {{trainCount}}, 'totalCount': {{totalTrainScheduleCount}} }) selected",
     "pacedTrainCountSelected_one": "1/{{totalCount}} service selected",
     "pacedTrainCountSelected_other": "{{count}}/{{totalCount}} services selected",

front/public/locales/fr/operational-studies.json

@@ -152,7 +152,7 @@
       "project": "Projeter",
       "restore": "Rétablir sur le modèle"
     },
-    "operationalPointIdentifier": "Identifiant de point",
+    "OperationalPointReference": "Référence de point",
     "pacedTrainAndTrainCount": "$t(main.pacedTrainCount, { 'count': {{pacedTrainCount}}, 'totalCount': {{totalPacedTrainCount}} }), $t(main.trainCount, { 'count': {{trainCount}}, 'totalCount': {{totalTrainScheduleCount}} }) sélectionnés",
     "pacedTrainCountSelected_one": "1/{{totalCount}} mission sélectionnée",
     "pacedTrainCountSelected_other": "{{count}}/{{totalCount}} missions sélectionnées",

front/src/applications/operationalStudies/helpers/TrainOpProjectionLazyLoader.ts

@@ -2,7 +2,7 @@ import { isEmpty } from 'lodash';
 
 import {
   osrdEditoastApi,
-  type OperationalPointIdentifier,
+  type OperationalPointReference,
   type PostPacedTrainOccupancyBlocksApiResponse,
   type PostPacedTrainProjectPathOpApiResponse,
   type PostTrainScheduleOccupancyBlocksApiResponse,
@@ -22,12 +22,12 @@ import TrainProjectionLazyLoaderAbstract, {
   type TrainProjectionLazyLoaderOptions,
 } from './TrainProjectionLazyLoaderAbstract';
 export default class TrainOpProjectionLazyLoader extends TrainProjectionLazyLoaderAbstract {
-  readonly opRefs: OperationalPointIdentifier[];
+  readonly opRefs: OperationalPointReference[];
 
   readonly opDistances: number[];
 
   constructor(
-    opRefs: OperationalPointIdentifier[],
+    opRefs: OperationalPointReference[],
     opDistances: number[],
     options: TrainProjectionLazyLoaderOptions
   ) {

front/src/applications/operationalStudies/hooks/usePathProjection.ts

@@ -11,7 +11,7 @@ import {
   type PathfindingResult,
   type OperationalPointPartReference,
   type PathProperties,
-  type OperationalPointIdentifier,
+  type OperationalPointReference,
 } from 'common/api/osrdEditoastApi';
 import { getExceptionFromOccurrenceId } from 'modules/timetableItem/helpers/pacedTrain';
 import type { TimetableItemId, TimetableItem } from 'reducers/osrdconf/types';
@@ -39,14 +39,14 @@ import { getStationFromOps } from '../utils';
  * Uses trigram --> UIC --> operational_point --> position-based fallbacks in priority order.
  */
 const getVirtualOpName = (
-  opId: OperationalPointIdentifier,
+  opRef: OperationalPointReference,
   index: number,
   totalCount: number,
   t: TFunction<'operational-studies'>
 ): string => {
-  if (opId.type === 'trigram') return opId.trigram;
-  if (opId.type === 'uic') return opId.uic.toString();
-  if (opId.type === 'id') return t('main.operationalPointIdentifier');
+  if (opRef.type === 'trigram') return opRef.trigram;
+  if (opRef.type === 'uic') return opRef.uic.toString();
+  if (opRef.type === 'id') return t('main.OperationalPointReference');
   if (index === 0) return t('main.requestedOrigin');
   if (index === totalCount - 1) return t('main.requestedDestination');
   return t('main.requestedPoint', { count: index + 1 });
@@ -59,29 +59,29 @@ const FALLBACK_DISTANCE_MM = 100_000_000;
  * Creates a virtual operational point with complete extensions when no infrastructure match is found.
  */
 const createVirtualOp = (
-  opId: OperationalPointIdentifier,
+  opRef: OperationalPointReference,
   index: number,
   totalCount: number,
   position: number,
   weight: number,
   t: TFunction<'operational-studies'>
 ): PathProperties['operational_points'][0] => {
-  const virtualName = getVirtualOpName(opId, index, totalCount, t);
+  const virtualName = getVirtualOpName(opRef, index, totalCount, t);
   const virtualId = `virtual_op_${virtualName}`;
 
   return {
     id: virtualId,
     extensions: {
       identifier: {
         name: virtualName,
-        uic: opId.type === 'uic' ? opId.uic : 0,
+        uic: opRef.type === 'uic' ? opRef.uic : 0,
       },
       sncf: {
-        ch: (opId.type !== 'id' && opId.secondary_code) || '',
+        ch: (opRef.type !== 'id' && opRef.secondary_code) || '',
         ch_long_label: '',
         ch_short_label: '',
-        ci: opId.type === 'uic' ? Number(formatUicToCi(opId.uic)) : 0,
-        trigram: opId.type === 'trigram' ? opId.trigram : '',
+        ci: opRef.type === 'uic' ? Number(formatUicToCi(opRef.uic)) : 0,
+        trigram: opRef.type === 'trigram' ? opRef.trigram : '',
       },
     },
     part: { track: '', position: 0 },

front/src/applications/operationalStudies/utils.ts

@@ -3,7 +3,7 @@ import { type Dictionary, isEqual } from 'lodash';
 
 import type {
   OperationalPoint,
-  OperationalPointIdentifier,
+  OperationalPointReference,
   OperationalPointPartReference,
   CorePathfindingResultSuccess,
   PathItemLocation,
@@ -471,10 +471,10 @@ export const groupRoundTrips = (
   return { oneWays, roundTrips, others };
 };
 
-export const getInvalidStepLabel = (opId: OperationalPointIdentifier) => {
-  if (opId.type === 'uic') return opId.uic.toString();
-  if (opId.type === 'trigram') return opId.trigram;
-  return opId.operational_point;
+export const getInvalidStepLabel = (opRef: OperationalPointReference) => {
+  if (opRef.type === 'uic') return opRef.uic.toString();
+  if (opRef.type === 'trigram') return opRef.trigram;
+  return opRef.operational_point;
 };
 
 export const matchOpRefAndOp = (