[REF] refactor code and add backward compatibility

Author: reichie020212

spp_api/controllers/api.py

@@ -207,7 +207,17 @@ def read_multi__GET(self, namespace, version, model, **kw):
         path = kw.get("path")
         del kw["path"]
 
-        page = kw.get("page", 1)
+        # For backward compatibility
+        # Will not use pagination
+        backward_compat = False
+        if "start_from" in kw:
+            backward_compat = True
+
+        try:
+            page = int(kw.get("page", 1))
+        except (ValueError, TypeError):
+            page = 1
+        page = max(1, page)
 
         kw = path.search_treatment_kwargs(kw)
         limit = kw.get("limit")
@@ -217,21 +227,25 @@ def read_multi__GET(self, namespace, version, model, **kw):
         records_all = records.search_count(kw.get("domain"))
         records_data = path._get_response_treatment(records_data)
 
-        pagination = {
-            "page": page,
-            "limit": limit,
-            "total_records": records_all,
-            "total_pages": (records_all + limit - 1) // limit,
-        }
-
         response_data = {
             "results": records_data,
             "version": version,
             "timestamp": datetime_format(datetime.datetime.now()),
             "reply_id": self.get_reply_id(),
-            "pagination": pagination,
         }
 
+        if backward_compat:
+            response_data["count"] = records_all
+            response_data["offset"] = kw.get("offset", 0)
+            response_data["limit"] = limit
+        else:
+            response_data["pagination"] = {
+                "page": page,
+                "limit": limit,
+                "total_records": records_all,
+                "total_pages": (records_all + limit - 1) // limit if limit > 0 else 1,
+            }
+
         return successful_response(200, response_data)
 
     # ReadOne (optional: include_fields, exclude_fields)

spp_api/models/spp_api_path.py

@@ -89,7 +89,7 @@ class SPPAPIPath(models.Model):
     # Read
     filter_domain = fields.Char(default="[]")
     field_ids = fields.Many2many("ir.model.fields", domain="[('model_id', '=', model_id)]", string="Fields")
-    limit = fields.Integer(string="Limit of results", default=80, help="Limit of results per page")
+    limit = fields.Integer(string="Limit of results", default=500, help="Limit of results per page")
     # Create / Update
     warning_required = fields.Boolean(compute="_compute_warning_required", compute_sudo=True)
     api_field_ids = fields.One2many("spp_api.field", "path_id", string="API Fields", copy=True)
@@ -663,24 +663,43 @@ def search_treatment_kwargs(self, kwargs):
         """
         self.ensure_one()
 
-        # Page
-        page = kwargs.get("page", 1)
-
-        # Get defined limit first in spp_api.path
-        # if limit is defined in kwargs (query parameter), use it; else use self.limit or MAX_LIMIT
-        limit = kwargs.get("limit", self.limit if self.limit else MAX_LIMIT)
-
-        # Validate limit
-        try:
-            limit = int(limit)
-        except (ValueError, TypeError):
-            limit = self.limit if self.limit else MAX_LIMIT
-
-        kwargs["limit"] = limit
-
-        # Offset
-        offset = (page - 1) * limit if page > 1 else kwargs.get("offset", 0)
-        kwargs["offset"] = offset
+        backward_compat = False
+        if "start_from" in kwargs:
+            backward_compat = True
+
+        if backward_compat:
+            limit = kwargs.get("limit", 0)
+            max_limit = self.limit if self.limit else MAX_LIMIT
+            kwargs["limit"] = limit if (limit and limit <= max_limit) else max_limit
+            kwargs["offset"] = kwargs.get("start_from", 0)
+            if "start_from" in kwargs:
+                del kwargs["start_from"]
+        else:
+            # Page
+            try:
+                page = int(kwargs.get("page", 1))
+            except (ValueError, TypeError):
+                page = 1
+            page = max(1, page)
+
+            # Get defined limit first in spp_api.path
+            # if limit is defined in kwargs (query parameter), use it; else use self.limit or MAX_LIMIT
+            max_limit = self.limit if self.limit else MAX_LIMIT
+            limit = kwargs.get("limit", max_limit)
+
+            # Validate limit
+            try:
+                limit = int(limit)
+                if limit <= 0 or limit > max_limit:
+                    limit = max_limit
+            except (ValueError, TypeError):
+                limit = max_limit
+
+            kwargs["limit"] = limit
+
+            # Offset
+            offset = (page - 1) * limit
+            kwargs["offset"] = offset
 
         # Domain
         kwargs["domain"] = self.get_domain(kwargs)