Skip to content
cpp-linter

fix: address Copilot review comments for Arduino 3.0 migration #965

Sign in to view logs

fix: address Copilot review comments for Arduino 3.0 migration

fix: address Copilot review comments for Arduino 3.0 migration #965

Triggered via push June 29, 2026 15:01
@hhvrchhvrc
pushed 9f602e8
feat/arduino-3.0
Status Success
Total duration 9m 39s
Artifacts –

cpp-linter.yml

on: push
get-vars  /  get-vars
18s
get-vars / get-vars
C/C++ Linter
5m 13s
C/C++ Linter
Fit to window
Zoom out
Zoom in

Annotations

1 error, 11 warnings, and 1 notice
components/util/include/Checksum.h:3:10 [clang-diagnostic-error]: components/util/include/Checksum.h#L3
'bit' file not found
get-vars / get-vars
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
components/http/include/http/HTTPRequestManager.h:72:242 [cppcoreguidelines-avoid-magic-numbers]: components/http/include/http/HTTPRequestManager.h#L72
10'000 is a magic number; consider replacing it with a named constant
components/http/include/http/HTTPRequestManager.h:72:25 [modernize-use-trailing-return-type]: components/http/include/http/HTTPRequestManager.h#L72
use a trailing return type for this function
components/http/include/http/HTTPRequestManager.h:40:24 [modernize-use-trailing-return-type]: components/http/include/http/HTTPRequestManager.h#L40
use a trailing return type for this function
components/http/include/http/HTTPRequestManager.h:40:5 [readability-redundant-inline-specifier]: components/http/include/http/HTTPRequestManager.h#L40
function 'ResultToString' has inline specifier but is implicitly inlined
components/http/include/http/HTTPRequestManager.h:40:5 [modernize-use-nodiscard]: components/http/include/http/HTTPRequestManager.h#L40
function 'ResultToString' should be marked [[nodiscard]]
components/http/include/http/HTTPRequestManager.h:33:40 [readability-identifier-length]: components/http/include/http/HTTPRequestManager.h#L33
parameter name 'd' is too short, expected at least 3 characters
components/http/include/http/HTTPRequestManager.h:33:35 [readability-identifier-length]: components/http/include/http/HTTPRequestManager.h#L33
parameter name 'c' is too short, expected at least 3 characters
components/http/include/http/HTTPRequestManager.h:33:28 [readability-identifier-length]: components/http/include/http/HTTPRequestManager.h#L33
parameter name 'r' is too short, expected at least 3 characters
components/http/include/http/HTTPRequestManager.h:15:14 [performance-enum-size]: components/http/include/http/HTTPRequestManager.h#L15
enum 'RequestResult' uses a larger base type ('int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size
components/http/include/http/HTTPRequestManager.h:1:1 [portability-avoid-pragma-once]: components/http/include/http/HTTPRequestManager.h#L1
avoid 'pragma once' directive; use include guards instead
Run clang-format on src/OtaUpdateManager.cpp: src/OtaUpdateManager.cpp#L0
File src/OtaUpdateManager.cpp does not conform to Custom style guidelines. (lines 5)