Number of sound effects incorrectly (or at least, misleadingly?) reported

[audigex]

nml/nml/actions/action11.py

Line 105 in 1b86893

generic.print_info("Sound effects: {}/{}".format(len(registered_sounds), NUM_ANIMATION_SOUNDS))

This stat entry reports eg 72/55 when I add 72 sounds, which appears to be based on an old limit of 127 or 128 sounds, I think? It's also confusing since it suggests a limit is being exceeded since 72 > 55

newGRF specs suggest the limit is much higher
https://newgrf-specs.tt-wiki.net/wiki/Action11

Presumably this should now be (eg) 72/32768 or similar?

[audigex]

GLX has suggested the correct number may now be 32 695 (0x8000 - 73), where 73 is the 73 original sound effects

With the original 55 figure being 0x80 - 73

[glx22]

Hmm but feat0A (industries) prop15 (Random sound effects) is limited to bytes.

[PeterN]

Some callbacks (animation stuff) use the upper 7 bits of the result to specify a sound index to play So the limit there is still 127, including the 73 original sounds. (It is per-NewGRF though, at least.)

[glx22]

And nml doesn't really validate ranges, seems it will happily accept values greater than 127 for industries prop15 but will actually crash (assert) for values above 255.

[audigex]

Perhaps the stats readout at the end of the compile could be changed to be more representative of what's actually happening?

"Sound effects: 72/55" is definitely confusing to the user, suggesting that they're adding too many sound effects with an unknown outcome, since no error has been thrown. My assumption when I first saw it was that I'd added 72 sound effects and would have 55 working sound effects.. so the 17 would either be overwritten by later ones, or ignored. Obviously that isn't (even close to) the case, but the confusing output suggests it is