Skip to content
This repository was archived by the owner on Aug 24, 2025. It is now read-only.

Commit 8f5388e

Browse files
committed
While recording: show BLE sensor name instead of address.
Fixes #1796.
1 parent 81a7882 commit 8f5388e

13 files changed

Lines changed: 14 additions & 34 deletions

src/main/java/de/dennisguse/opentracks/sensors/BluetoothConnectionManager.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -139,11 +139,11 @@ synchronized void connect(Context context, Handler handler, @NonNull BluetoothDe
139139

140140
bluetoothGatt = device.connectGatt(context, false, connectCallback, BluetoothDevice.TRANSPORT_AUTO, 0, handler);
141141

142-
observer.onConnect(sensorHandler.createEmptySensorData(bluetoothGatt.getDevice().getAddress()));
142+
observer.onConnect(sensorHandler.createEmptySensorData(device.getAddress(), device.getName()));
143143
}
144144

145145
private synchronized void clearData() {
146-
observer.onDisconnect(sensorHandler.createEmptySensorData(bluetoothGatt.getDevice().getAddress()));
146+
observer.onDisconnect(sensorHandler.createEmptySensorData(bluetoothGatt.getDevice().getAddress(), bluetoothGatt.getDevice().getName()));
147147
}
148148

149149
synchronized void disconnect() {

src/main/java/de/dennisguse/opentracks/sensors/BluetoothHandlerBarometricPressure.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public List<ServiceMeasurementUUID> getServices() {
2222
}
2323

2424
@Override
25-
public Aggregator<?, ?> createEmptySensorData(String address) {
25+
public Aggregator<?, ?> createEmptySensorData(String address, String name) {
2626
return null; //TODO
2727
}
2828

src/main/java/de/dennisguse/opentracks/sensors/BluetoothHandlerCyclingCadence.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ public List<ServiceMeasurementUUID> getServices() {
2424
}
2525

2626
@Override
27-
public AggregatorCyclingCadence createEmptySensorData(String address) {
28-
return new AggregatorCyclingCadence(address);
27+
public AggregatorCyclingCadence createEmptySensorData(String address, String name) {
28+
return new AggregatorCyclingCadence(address, name);
2929
}
3030

3131
@Override

src/main/java/de/dennisguse/opentracks/sensors/BluetoothHandlerCyclingDistanceSpeed.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ public List<ServiceMeasurementUUID> getServices() {
2626
}
2727

2828
@Override
29-
public AggregatorCyclingDistanceSpeed createEmptySensorData(String address) {
30-
return new AggregatorCyclingDistanceSpeed(address);
29+
public AggregatorCyclingDistanceSpeed createEmptySensorData(String address, String name) {
30+
return new AggregatorCyclingDistanceSpeed(address, name);
3131
}
3232

3333
@Override

src/main/java/de/dennisguse/opentracks/sensors/BluetoothHandlerManagerCyclingPower.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ public List<ServiceMeasurementUUID> getServices() {
2626
}
2727

2828
@Override
29-
public AggregatorCyclingPower createEmptySensorData(String address) {
30-
return new AggregatorCyclingPower(address);
29+
public AggregatorCyclingPower createEmptySensorData(String address, String name) {
30+
return new AggregatorCyclingPower(address, name);
3131
}
3232

3333
@Override

src/main/java/de/dennisguse/opentracks/sensors/BluetoothHandlerManagerHeartRate.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@ public List<ServiceMeasurementUUID> getServices() {
3636
}
3737

3838
@Override
39-
public AggregatorHeartRate createEmptySensorData(String address) {
40-
return new AggregatorHeartRate(address);
39+
public AggregatorHeartRate createEmptySensorData(String address, String name) {
40+
return new AggregatorHeartRate(address, name);
4141
}
4242

4343
@Override

src/main/java/de/dennisguse/opentracks/sensors/BluetoothHandlerRunningSpeedAndCadence.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@ public List<ServiceMeasurementUUID> getServices() {
2929
}
3030

3131
@Override
32-
public AggregatorRunning createEmptySensorData(String address) {
33-
return new AggregatorRunning(address);
32+
public AggregatorRunning createEmptySensorData(String address, String name) {
33+
return new AggregatorRunning(address, name);
3434
}
3535

3636
@Override

src/main/java/de/dennisguse/opentracks/sensors/sensorData/AggregatorCyclingCadence.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,6 @@ public class AggregatorCyclingCadence extends Aggregator<BluetoothHandlerCycling
1414

1515
private final String TAG = AggregatorCyclingCadence.class.getSimpleName();
1616

17-
public AggregatorCyclingCadence(String sensorAddress) {
18-
super(sensorAddress);
19-
}
20-
2117
public AggregatorCyclingCadence(String sensorAddress, String sensorName) {
2218
super(sensorAddress, sensorName);
2319
}

src/main/java/de/dennisguse/opentracks/sensors/sensorData/AggregatorCyclingDistanceSpeed.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,6 @@ public class AggregatorCyclingDistanceSpeed extends Aggregator<BluetoothHandlerC
1717

1818
private Distance wheelCircumference;
1919

20-
public AggregatorCyclingDistanceSpeed(String sensorAddress) {
21-
super(sensorAddress);
22-
}
23-
2420
public AggregatorCyclingDistanceSpeed(String sensorAddress, String sensorName) {
2521
super(sensorAddress, sensorName);
2622
}

src/main/java/de/dennisguse/opentracks/sensors/sensorData/AggregatorCyclingPower.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,6 @@
66

77
public class AggregatorCyclingPower extends Aggregator<Power, Power> {
88

9-
public AggregatorCyclingPower(String address) {
10-
super(address);
11-
}
12-
139
public AggregatorCyclingPower(String name, String address) {
1410
super(name, address);
1511
}

0 commit comments

Comments
 (0)