echo.c: Avoid -Wsign-compare with MinGW on 32bit systems

flichtenheld · cron2 · commit 5f844605ee52 · 2025-02-18T14:03:22.000+01:00
echo.c:221:72: error: comparison of integer expressions of
different signedness: ‘long unsigned int’ and
‘time_t’ {aka ‘long int’} [-Werror=sign-compare]

Signed-off-by: Frank Lichtenheld &lt;frank@lichtenheld.com&gt;
diff --git a/echo.c b/echo.c
@@ -218,7 +218,8 @@ echo_msg_repeated(const struct echo_msg *msg)
     const struct echo_msg_history *hist;
 
     hist = echo_msg_recall(msg->fp.digest, msg->history);
-    return (hist && (hist->fp.timestamp + o.popup_mute_interval * 3600 > msg->fp.timestamp));
+    return (hist
+            && (hist->fp.timestamp + (time_t)(o.popup_mute_interval * 3600) > msg->fp.timestamp));
 }
 
 /* Append a line of echo msg */

Original file line number	Diff line number	Diff line change
`@@ -218,7 +218,8 @@ echo_msg_repeated(const struct echo_msg *msg)`
`218`	`218`	`const struct echo_msg_history *hist;`
`219`	`219`
`220`	`220`	`hist = echo_msg_recall(msg->fp.digest, msg->history);`
`221`		`- return (hist && (hist->fp.timestamp + o.popup_mute_interval * 3600 > msg->fp.timestamp));`
	`221`	`+ return (hist`
	`222`	`+ && (hist->fp.timestamp + (time_t)(o.popup_mute_interval * 3600) > msg->fp.timestamp));`
`222`	`223`	`}`
`223`	`224`
`224`	`225`	`/* Append a line of echo msg */`