Fix NRPT issue without writing into the registry

[irwir]

The issue was Missing NRPT keys on Windows Server 2019, and for the fix commit df4863a was created.
The issue was closed, but the fix could be improved.

The service fails to start automatically on boot, but successfully runs with manual start - this implies that registry entries are not strictly required.
On Windows absence of policy/registry records commonly have a predefined interpretation, and programs could be expected to behave accordingly.
Therefore, creation of the registry record should be avoided; while the service would be using appropriate defaults - as it probably does on manual start.

[lstipakov]

Aren't we mixing two issues here?

• service crash (if we are talking about the same crash) was due to missing event source, which is now created during installation and not by service itself (which doesn't event have permissions to create it)
• NRPT is about applyyng DNS and other settings, and it should not be related to the crash

What problem exactly are you experiencing? Please provide the logs.

[irwir]

Aren't we mixing two issues here?

I am not.

1. Service crash was fixed and this is already in alpha2-I003. Otherwise the service could be started only as SYSTEM.
2. NRPT error prevents automatic service start on reboot. Probably the last consistently starting version was in 2.5.2.
   Not fixed in alpha2-I003. No crash, just fail, and the error is the same as before:
   openvpnserv error:
   DeleteNrptRules: could not open NRPT base key (2)

But the service could be started manually, which means that absense of the registry entry could be handled without adding records into the registry.

[cron2]

So, since this has been sitting idle for a while - is this still a problem with 2.7_beta1-I005? If yes, what exactly needs to be reworked?

[irwir]

The idea was to ignore the absent registry keys and just continue, as these keys are optional.

The main issue now is that openvpnserv2 starts after install, but fails to start on reboot (moved the description to a new issue in the service repository).

[d12fk]

This issue is now tracked in #29