Skip to content

Commit 582b06e

Browse files
committed
Apply the CodeRabbit recommendations
1 parent ced7da2 commit 582b06e

3 files changed

Lines changed: 15 additions & 1 deletion

File tree

ansible/roles/ovos_timezone/tasks/main.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
ovos_timezone_name: "{{ ovos_timezone_value }}"
2828

2929
- name: Set system's timezone on Linux
30+
become: true
3031
community.general.timezone:
3132
name: "{{ ovos_timezone_value }}"
3233
when: ansible_facts.system == 'Linux'

ansible/roles/ovos_virtualenv/defaults/main.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,13 @@ ovos_virtualenv_rust_messagebus_version: v1.1.2
2727
ovos_virtualenv_rust_messagebus_target_arch: >-
2828
{{ 'aarch64' if ansible_facts.architecture in ['aarch64', 'arm64']
2929
else 'x86_64' if ansible_facts.architecture in ['x86_64', 'amd64']
30+
else 'armv7' if ansible_facts.architecture in ['armv7', 'armv7l']
31+
else 'arm' if ansible_facts.architecture in ['arm', 'armv6', 'armv6l']
3032
else ansible_facts.architecture }}
3133
ovos_virtualenv_rust_messagebus_target_platform: >-
32-
{{ 'apple-darwin' if ansible_facts.system == 'Darwin' else 'unknown-linux-gnu' }}
34+
{{ 'apple-darwin' if ansible_facts.system == 'Darwin'
35+
else 'unknown-linux-gnueabihf' if ovos_virtualenv_rust_messagebus_target_arch in ['arm', 'armv7']
36+
else 'unknown-linux-gnu' }}
3337
ovos_virtualenv_rust_messagebus_binary_name: >-
3438
ovos_messagebus-{{ ovos_virtualenv_rust_messagebus_target_arch }}-{{ ovos_virtualenv_rust_messagebus_target_platform }}
3539
ovos_virtualenv_rust_messagebus_archive_name: "{{ ovos_virtualenv_rust_messagebus_binary_name }}.tar.gz"

tests/bats/code_quality.bats

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -226,6 +226,12 @@ function setup() {
226226
run grep -q "ovos_messagebus-x86_64-apple-darwin.tar.gz" ansible/roles/ovos_virtualenv/defaults/main.yml
227227
assert_success
228228

229+
run grep -q "armv7l" ansible/roles/ovos_virtualenv/defaults/main.yml
230+
assert_success
231+
232+
run grep -q "unknown-linux-gnueabihf" ansible/roles/ovos_virtualenv/defaults/main.yml
233+
assert_success
234+
229235
run grep -q "ansible.builtin.get_url" ansible/roles/ovos_virtualenv/tasks/bus.yml
230236
assert_success
231237

@@ -435,6 +441,9 @@ function setup() {
435441
run grep -q "Set system's timezone on Linux" ansible/roles/ovos_timezone/tasks/main.yml
436442
assert_success
437443

444+
run bash -c "grep -A5 -F -- \"- name: Set system's timezone on Linux\" ansible/roles/ovos_timezone/tasks/main.yml | grep -q -- \"become: true\""
445+
assert_success
446+
438447
run grep -q "community.general.timezone" ansible/roles/ovos_timezone/tasks/main.yml
439448
assert_success
440449

0 commit comments

Comments
 (0)