Make sure .config/systemd is not created on macos

Author: goldyfruit

ansible/roles/ovos_config/defaults/main.yml

@@ -3,10 +3,9 @@ ovos_config_hotword_sensitivity: "{{ ovos_installer_hotword_sensitivity | defaul
 ovos_config_hotword_trigger_level: "{{ ovos_installer_hotword_trigger_level | default(1) }}"
 ovos_config_listener_multiplier: "{{ ovos_installer_listener_multiplier | default(1.5) }}"
 
-ovos_config_backup_paths:
+ovos_config_backup_paths_common:
   - "{{ ovos_installer_user_home }}/ovos/*"
   - "{{ ovos_installer_user_home }}/hivemind/*"
-  - "{{ ovos_installer_user_home }}/.config/systemd/user/*"
   - "{{ ovos_installer_user_home }}/.config/mycroft/*"
   - "{{ ovos_installer_user_home }}/.config/hivemind/*"
   - "{{ ovos_installer_user_home }}/.config/OpenVoiceOS/*"
@@ -16,6 +15,11 @@ ovos_config_backup_paths:
   - "{{ ovos_installer_user_home }}/.local/share/hivemind/*"
   - "{{ ovos_installer_user_home }}/.local/state/ovos/*"
   - "{{ ovos_installer_user_home }}/.local/state/mycroft/*"
+ovos_config_backup_paths: >-
+  {{
+    ovos_config_backup_paths_common
+    + ([ovos_installer_user_home + '/.config/systemd/user/*'] if ansible_facts.system == 'Linux' else [])
+  }}
 ovos_config_backup_dest: "{{ ovos_installer_user_home }}/ovos-backup.tar.gz"
 ovos_config_backup_owner: "{{ ovos_installer_user }}"
 ovos_config_backup_group: "{{ ovos_installer_group }}"
@@ -29,7 +33,7 @@ ovos_config_container_dir_owner: "{{ ovos_installer_user }}"
 ovos_config_container_dir_group: "{{ ovos_installer_group }}"
 ovos_config_container_dir_mode: "0755"
 ovos_config_container_directories:
-  - { path: "{{ ovos_installer_user_home }}/.config/systemd/user", enabled: true }
+  - { path: "{{ ovos_installer_user_home }}/.config/systemd/user", enabled: "{{ ansible_facts.system == 'Linux' }}" }
   - { path: "{{ ovos_installer_user_home }}/ovos", enabled: true }
   - { path: "{{ ovos_installer_user_home }}/ovos/config", enabled: true }
   - { path: "{{ ovos_installer_user_home }}/ovos/config/persona", enabled: true }
@@ -49,7 +53,7 @@ ovos_config_virtualenv_directories:
   - { path: "{{ ovos_installer_user_home }}/.local", enabled: true }
   - { path: "{{ ovos_installer_user_home }}/.local/bin", enabled: true }
   - { path: "{{ ovos_installer_user_home }}/.config/hivemind", enabled: "{{ ovos_installer_profile != 'ovos' }}" }
-  - { path: "{{ ovos_installer_user_home }}/.config/systemd/user", enabled: true }
+  - { path: "{{ ovos_installer_user_home }}/.config/systemd/user", enabled: "{{ ansible_facts.system == 'Linux' }}" }
   - { path: "{{ ovos_installer_user_home }}/nltk_data", enabled: true }
 
 ovos_config_geoip_url: "{{ ovos_installer_geoip_url }}"

tests/bats/code_quality.bats

@@ -475,6 +475,20 @@ function setup() {
     assert_success
 }
 
+@test "macos_does_not_require_systemd_user_config_paths" {
+    run grep -q "ovos_config_backup_paths_common" ansible/roles/ovos_config/defaults/main.yml
+    assert_success
+
+    run grep -q "ansible_facts.system == 'Linux'" ansible/roles/ovos_config/defaults/main.yml
+    assert_success
+
+    run grep -F -q '.config/systemd/user", enabled: "{{ ansible_facts.system == '\''Linux'\'' }}"' ansible/roles/ovos_config/defaults/main.yml
+    assert_success
+
+    run grep -F -q "/.config/systemd/user/*'] if ansible_facts.system == 'Linux' else []" ansible/roles/ovos_config/defaults/main.yml
+    assert_success
+}
+
 @test "homeassistant_url_defaults_port_only_for_http" {
     run grep -q 'if \[ "\$proto" == "http" \]; then' tui/homeassistant.sh
     assert_success