Fix for noisy load of ruby_smb gem

Author: nmburgan

lib/bolt/transport/winrm/connection.rb

@@ -162,9 +162,20 @@ def upload_file_winrm(source, destination)
           raise Bolt::Node::FileError.new(e.message, 'WRITE_ERROR')
         end
 
-        def upload_file_smb(source, destination)
+        def require_ruby_smb
           # lazy-load expensive gem code
+          # In BinData 2.5.0+, the below commit makes things VERY noisy when loading RubySMB, so
+          # we temporarily disable warnings while we load it. If this ever gets fixed, get rid
+          # of this function and restore the plain 'require' where this function is called.
+          # https://github.com/dmendel/bindata/commit/2c8588a1ae5959080fffa429e07027f2ff20161c
+          prev = $VERBOSE
+          $VERBOSE = nil
           require 'ruby_smb'
+          $VERBOSE = prev
+        end
+
+        def upload_file_smb(source, destination)
+          require_ruby_smb
 
           win_dest = destination.tr('/', '\\')
           if (md = win_dest.match(/^([a-z]):\\(.*)/i))
@@ -215,8 +226,7 @@ def download_file_winrm(source, destination, download)
         end
 
         def download_file_smb(source, destination)
-          # lazy-load expensive gem code
-          require 'ruby_smb'
+          require_ruby_smb
 
           win_source = source.tr('/', '\\')
           if (md = win_source.match(/^([a-z]):\\(.*)/i))

spec/spec_helper.rb

@@ -12,7 +12,13 @@
 require 'puppet_pal'
 # HACK: must be loaded prior to spec libs that implement stub to prevent
 # RubySMB::Dcerpc::Request from shadowing 'stub' through BinData::DSLMixin::DSLFieldValidator
+# In BinData 2.5.0+, the below commit makes things VERY noisy when loading RubySMB, so
+# we temporarily disable warnings while we load it.
+# https://github.com/dmendel/bindata/commit/2c8588a1ae5959080fffa429e07027f2ff20161c
+prev = $VERBOSE
+$VERBOSE = nil
 require 'ruby_smb'
+$VERBOSE = prev
 
 ENV['RACK_ENV'] = 'test'
 $LOAD_PATH.unshift File.join(__dir__, 'lib')