Skip to content

Commit 1f84ea7

Browse files
committed
cleaner local facts filter
Just a trivial refactor that I forgot to do before submitting #240
1 parent 645dd4a commit 1f84ea7

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

lib/puppet/node/facts.rb

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,12 @@ def save(instance, key = nil, options = {})
2929

3030
def add_local_facts(query = [])
3131
query = Array(query) # some use cases result in a nil being passed in
32-
values["implementation"] = Puppet.implementation if query.empty? or query.include? 'implementation'
33-
values["clientcert"] = Puppet.settings[:certname] if query.empty? or query.include? 'clientcert'
34-
values["clientversion"] = Puppet.version.to_s if query.empty? or query.include? 'clientversion'
35-
values["clientnoop"] = Puppet.settings[:noop] if query.empty? or query.include? 'clientnoop'
32+
return if query.empty?
33+
34+
values["implementation"] = Puppet.implementation if query.include? 'implementation'
35+
values["clientcert"] = Puppet.settings[:certname] if query.include? 'clientcert'
36+
values["clientversion"] = Puppet.version.to_s if query.include? 'clientversion'
37+
values["clientnoop"] = Puppet.settings[:noop] if query.include? 'clientnoop'
3638
end
3739

3840
def initialize(name, values = {})

0 commit comments

Comments
 (0)