Notify now honors withpath parameter

Notify should not represent a state of a resource since it only "exists"
during execution time. This change proposes that it should be considered
to always "exist", thus avoiding a change notification.

Signed-off-by: Igor Nogueira de Oliveira <igor@acumera.com>

Author: Igor Nogueira de Oliveira

lib/puppet/type/notify.rb

@@ -11,25 +11,21 @@ module Puppet
 
     newproperty(:message, :idempotent => false) do
       desc "The message to be sent to the log. Note that the value specified must be a string."
-      def sync
+      def insync?(is)
         message = @sensitive ? 'Sensitive [value redacted]' : should
         case @resource["withpath"]
         when :true
           send(@resource[:loglevel], message)
         else
           Puppet.send(@resource[:loglevel], message)
         end
-        nil
+        true
       end
 
       def retrieve
         :absent
       end
 
-      def insync?(is)
-        false
-      end
-
       defaultto { @resource[:name] }
     end