lint: minor cleanup - part 2

Note: The signing key in testdata was changed to accomodate upstream cryptography-module change
in v43.0.0 (2024-07-20): serialize_certificates() now emits ASN.1 that more closely follows the recommendations in RFC 2315.

Author: tuxuser

tests/conftest.py

@@ -24,7 +24,7 @@
 
 
 @pytest_asyncio.fixture(scope="function")
-async def auth_mgr(event_loop):
+async def auth_mgr():
     session = SignedSession()
     mgr = AuthenticationManager(session, "abc", "123", "http://localhost")
     mgr.oauth = OAuth2TokenResponse.model_validate_json(
@@ -37,7 +37,7 @@ async def auth_mgr(event_loop):
 
 
 @pytest_asyncio.fixture(scope="function")
-async def xal_mgr(event_loop):
+async def xal_mgr():
     session = SignedSession()
     mgr = XALManager(
         session,

tests/data/test_signing_key.pem

@@ -1,5 +1,5 @@
 -----BEGIN EC PRIVATE KEY-----
-MHcCAQEEIObr5IVtB+DQcn25+R9n4K/EyUUSbVvxIJY7WhVeELUuoAoGCCqGSM49
-AwEHoUQDQgAEOKyCQ9qH5U4lZcS0c5/LxIyKvOpKe0l3x4Eg5OgDbzezKNLRgT28
-fd4Fq3rU/1OQKmx6jSq0vTB5Ao/48m0iGg==
+MHcCAQEEIObr5IVtB+DQcn25+R9n4K/EyUUSbVvxIJY7WhVeELUuoAoGCCqGSM49AwEHoUQDQgAE
+OKyCQ9qH5U4lZcS0c5/LxIyKvOpKe0l3x4Eg5OgDbzezKNLRgT28fd4Fq3rU/1OQKmx6jSq0vTB5
+Ao/48m0iGg==
 -----END EC PRIVATE KEY-----

tests/test_ratelimits.py

@@ -146,7 +146,7 @@ async def helper_reach_and_wait_for_burst(
     make_request, start_time, burst_limit: int, expected_counter: int
 ):
     # Make as many requests as possible without exceeding the BURST limit.
-    for i in range(burst_limit):
+    for _ in range(burst_limit):
         await make_request()
 
     # Make another request, ensure that it raises the exception.
@@ -202,7 +202,7 @@ async def make_request():
     )
 
     # Now, make the rest of the requests (10 left, 20/30 done!)
-    for i in range(10):
+    for _ in range(10):
         await make_request()
 
     # Wait for the burst limit to 'reset'.

xbox/webapi/api/provider/ratelimitedprovider.py

@@ -63,10 +63,10 @@ def __handle_rate_limit_setup(self):
     def __parse_rate_limit_key(
         self, key: Union[int, Dict[str, int]], period: TimePeriod
     ) -> ParsedRateLimit:
-        key_type = type(key)
-        if isinstance(key_type, int):
+        if isinstance(key, int) and not isinstance(key, bool):
+            # bool is a subclass of int, hence the explicit check
             return ParsedRateLimit(read=key, write=key, period=period)
-        elif isinstance(key_type, dict):
+        elif isinstance(key, dict):
             # TODO: schema here?
             # Since the key-value pairs match we can just pass the dict to the model
             return ParsedRateLimit(**key, period=period)