Governor using multiple tokens for votes

[EmanuelCampos]

🧐 Motivation
It's a feature that will provide an Extension to use more than one token with Governor.

📝 Details

• need to be an extension
• need to accept a list of tokens
• need to provide support to governance and getPastVotes/ getPastTotalSupply

[EmanuelCampos]

@frangio could you tell me why this approach doesn't work? could you give me suggestions to improve it?

[frangio]

Thanks for the suggestion. Before submitting a PR, can you provide some more context? What is the use case that made you interested in this feature?

If we implement this, it should probably be a Governor module similar to GovernorVotes. The important part is implementing the _getVotes function.

[EmanuelCampos]

@frangio it will be a Governance with 2 tokens, to two different people, like staking tokens and the common token, so who have the staking token have the governance power too, and it can grow more to other tokens

[EmanuelCampos]

@frangio I was using the getPastVotes, is it much different from my Implementation?

[frangio]

Yes, it's very different. All that's needed is _getVotes. Please read the code and make sure you understand that.

I'm concerned about the storage overhead that it will imply for castVote. I think this feature should wait until there are immutable arrays (ethereum/solidity#12587), which are allegedly being worked on.

I would put this feature request on hold, but I encourage you to implement it in your project for 2 tokens based on GovernorVotes.

[Amxx]

@EmanuelCampos
Relevant piece of code: https://github.com/p00ls/contracts/blob/master/contracts/dao/P00lsDAO.sol#L41-L52

[EmanuelCampos]

@Amxx @frangio aI believe this both approaches using only getVotes will not provide support to

openzeppelin-contracts/contracts/governance/extensions/GovernorVotesQuorumFraction.sol

Lines 47 to 49 in 65b4572

	function quorum(uint256 blockNumber) public view virtual override returns (uint256) {
	return (token.getPastTotalSupply(blockNumber) * quorumNumerator()) / quorumDenominator();
	}

so I did this implementation thinking on this case, because the voting weight will be token + tokenX

[frangio]

I see. It's true that the quorum module becomes incompatible. With the approach I suggested I would include the quorum logic along with the custom _getVotes implementation. I'm not sure that deploying a separate contract to wrap the multiple tokens is the right way to implement this.

[bilalmotiwala]

Hey folks! Just sort of checking in on this. Was anyone able to actually come up with a way to use multiple tokens for their governance?

[Amxx]

Hey folks! Just sort of checking in on this. Was anyone able to actually come up with a way to use multiple tokens for their governance?

If all your tokens are voting tokens, you can follow this approach https://github.com/p00ls/contracts/blob/master/contracts/dao/P00lsDAO.sol#L41-L52

• override _getVotes
  • call getPastVotes for all your contracts
  • sum that up
  • return that "aggregated" vote count.