Skip to content
This repository has been archived by the owner on Aug 6, 2020. It is now read-only.
This repository has been archived by the owner on Aug 6, 2020. It is now read-only.

Review naming #9

Open
Open
@frangio

Description

There's a couple of names I think we should review.

  • Web3Context: This library will generally be used alongside React, where Context already has a meaning that is unrelated to how we're using the word.
  • web3Context.lib: The lib property on Web3Context instances holds the Web3 instance initialized with the provider. It's a very generic name. IMO, ideally the property would be web3.
  • useWeb3Network/fromConnection: This React hook and its corresponding factory have unrelated names, even though they are both wrappers around the same functionality.

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions