Skip to content
This repository was archived by the owner on Jan 24, 2022. It is now read-only.

Commit c375d2c

Browse files
spalladinojbcarpanelli
authored andcommitted
Use OpenZeppelin fork of resolver engine (#1066)
* Use OpenZeppelin fork of resolver engine Adds fix to handle Windows-like paths. Fixes #1049 * Use platform independent path separator
1 parent 1c50188 commit c375d2c

File tree

5 files changed

+66
-27
lines changed

5 files changed

+66
-27
lines changed

packages/cli/package-lock.json

Lines changed: 56 additions & 21 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/cli/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,8 @@
5555
"homepage": "https://github.com/OpenZeppelin/openzeppelin-sdk/tree/master/packages/cli#readme",
5656
"dependencies": {
5757
"@openzeppelin/upgrades": "2.5.0-rc.1",
58-
"@resolver-engine/imports-fs": "^0.3.2",
58+
"@openzeppelin/resolver-engine-core": "^0.3.3",
59+
"@openzeppelin/resolver-engine-imports-fs": "^0.3.3",
5960
"@types/fs-extra": "^7.0.0",
6061
"@types/npm": "^2.0.29",
6162
"@types/semver": "^5.5.0",

packages/cli/src/models/compiler/solidity/ResolverEngineGatherer.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { ResolverEngine } from '@resolver-engine/core';
1+
import { ResolverEngine } from '@openzeppelin/resolver-engine-core';
22
import pathSys from 'path';
33
import urlSys from 'url';
44
import { getImports } from '../../../utils/solidity';
@@ -95,7 +95,7 @@ export async function gatherSources(
9595
const alreadyImported = new Set();
9696

9797
if (workingDir !== '') {
98-
workingDir += '/';
98+
workingDir += pathSys.sep;
9999
}
100100

101101
const absoluteRoots = roots.map(what => resolvePath(workingDir, what));

packages/cli/src/models/compiler/solidity/SolidityContractsCompiler.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import path from 'path';
12
import flatMap from 'lodash.flatmap';
23
import { Loggy } from '@openzeppelin/upgrades';
34
import solc, {
@@ -168,8 +169,10 @@ class SolidityContractsCompiler {
168169
private _buildContractSchema(solcOutput: CompilerOutput, fileName: string, contractName: string): CompiledContract {
169170
const output = solcOutput.contracts[fileName][contractName];
170171
const source = solcOutput.sources[fileName];
171-
fileName = fileName.substring(fileName.lastIndexOf('/') + 1);
172-
const contract = this.contracts.find(aContract => aContract.fileName === fileName);
172+
fileName = path.basename(fileName);
173+
const contract = this.contracts.find(
174+
aContract => aContract.fileName === fileName,
175+
);
173176

174177
return {
175178
fileName,

packages/cli/src/models/compiler/solidity/SolidityProjectCompiler.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import {
1616
DEFAULT_OPTIMIZER,
1717
DEFAULT_EVM_VERSION,
1818
} from './SolidityContractsCompiler';
19-
import { ImportsFsEngine } from '@resolver-engine/imports-fs';
19+
import { ImportsFsEngine } from '@openzeppelin/resolver-engine-imports-fs';
2020
import { gatherSources } from './ResolverEngineGatherer';
2121
import { SolcBuild } from './CompilerProvider';
2222
import { compilerVersionsMatch, compilerSettingsMatch } from '../../../utils/solidity';

0 commit comments

Comments
 (0)