Skip to content

[Feature]: Investigate How to Address export-abi Warnings #439

Open
@0xNeshi

Description

@0xNeshi

What is the feature you would like to see?

By declaring export-abi feature, we can remove those pesky warnings.
The problem is that cargo hack workflow fails when it tried to activate this feature with the trait `SolError` is not implemented for `[OUR_ERROR_NAME]` .
We should investigate why this is, so that we can declare the feature in Cargo.toml.

Alternatively, we can simply skip this feature, just as we do for std EDIT: We shouldn't skip this feature, as it's often used in development. We should support it.

Original comment: #437 (comment)

Related #436

Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines

Metadata

Metadata

Assignees

Labels

type: bugSomething is not working as intended.

Type

No type

Projects

Status

In Progress

Relationships

None yet

Development

No branches or pull requests

Issue actions