This repository has been archived by the owner on Aug 6, 2020. It is now read-only.
This repository has been archived by the owner on Aug 6, 2020. It is now read-only.
./node_modules/web3-eth-accounts/src/scrypt.js Critical dependency: the request of a dependency is an expression #41
Open
Description
Running the client npm start
in the client
directory gives the following warning:
Compiled with warnings.
./node_modules/web3-eth-accounts/src/scrypt.js
Critical dependency: the request of a dependency is an expression
Search for the keywords to learn more about each warning.
To ignore, add // eslint-disable-next-line to the line before.
Checking dependencies:
$ npm ls web3-eth-accounts
client@0.1.0 /c/Users/andre/Documents/projects/forum/starter/client
└─┬ web3@1.2.1
└─┬ web3-eth@1.2.1
└── web3-eth-accounts@1.2.1
The issue is apparently resolved in web3@1.2.2 according to: web3/web3.js#3018
Activity
nivida commentedon Jan 6, 2020
@abcoathup Yes, this got already fixed and released but be aware to update your package-lock file :)
nventuro commentedon Jan 14, 2020
This should be fixed with #35 and #36. @abcoathup can you check?
abcoathup commentedon Jan 16, 2020
@nventuro
https://github.com/OpenZeppelin/starter-kit-gsn/blob/master/client/package.json uses web3@1.2.1 so it isn't fixed yet.
nventuro commentedon Jan 16, 2020
Ohh I missed the fact that we have a direct dependency. I think we can safely update it though.