fix(app): fix error recovery crashing the app (#15837)

Closes RQA-2887

Author: mjhuff

app/src/organisms/ErrorRecoveryFlows/__tests__/ErrorRecoveryFlows.test.tsx

@@ -218,7 +218,7 @@ describe('ErrorRecoveryFlows', () => {
 
     const newProps = {
       ...props,
-      failedCommand: { ...mockFailedCommand, id: 'NEW_ID' },
+      failedCommand: null,
     }
     rerender(<ErrorRecoveryFlows {...newProps} />)
     expect(mockReportErrorEvent).toHaveBeenCalledWith(newProps.failedCommand)

app/src/organisms/ErrorRecoveryFlows/hooks/useFailedLabwareUtils.ts

@@ -57,7 +57,7 @@ export function useFailedLabwareUtils({
 }: UseFailedLabwareUtilsProps): UseFailedLabwareUtilsResult {
   const recentRelevantFailedLabwareCmd = React.useMemo(
     () => getRelevantFailedLabwareCmdFrom({ failedCommand, runCommands }),
-    [failedCommand, runCommands]
+    [failedCommand?.key, runCommands]
   )
 
   const tipSelectionUtils = useTipSelectionUtils(recentRelevantFailedLabwareCmd)

app/src/organisms/ErrorRecoveryFlows/hooks/useRecoveryTakeover.ts

@@ -62,7 +62,7 @@ export function useRecoveryTakeover(
         clearClientData()
       }
     }
-  }, [clearClientData, isActiveUser])
+  }, [isActiveUser])
 
   const showTakeover = !(activeId == null || thisUserId === activeId)
 

app/src/organisms/ErrorRecoveryFlows/index.tsx

@@ -121,7 +121,7 @@ export function ErrorRecoveryFlows(
   const analytics = useRecoveryAnalytics()
   React.useEffect(() => {
     analytics.reportErrorEvent(failedCommand)
-  }, [failedCommand])
+  }, [failedCommand?.key])
 
   const { hasLaunchedRecovery, toggleERWizard, showERWizard } = useERWizard()
   const isOnDevice = useSelector(getIsOnDevice)