refactor(app): refactor ODD protocol card copy when run data is not "…

…ok" (#17261)

Closes RQA-3851

When protocol cards have not ok run data, we can't retrieve the completedAt timestamp, and the fallback has been the current date, which is confusing copy. After speaking with Design, the plan is to remove copy if we can't retrieve the completedAt timestamp.

app/src/organisms/ODD/RobotDashboard/RecentRunProtocolCard.tsx

@@ -158,15 +158,22 @@ export function ProtocolWithLastRun({
     [RUN_STATUS_SUCCEEDED]: t('completed'),
     [RUN_STATUS_FAILED]: t('failed'),
   }
-  // TODO(BC, 2023-06-05): see if addSuffix false allow can remove usage of .replace here
-  const formattedLastRunTime = formatDistance(
-    // Fallback to current date if completedAt is null, though this should never happen since runs must be completed to appear in dashboard
-    new Date(runData.completedAt ?? new Date()),
-    new Date(),
-    {
-      addSuffix: true,
+  const formattedLastRunTime =
+    runData.completedAt != null
+      ? formatDistance(new Date(runData.completedAt), new Date(), {
+          addSuffix: true,
+        }).replace('about ', '')
+      : null
+  const buildLastRunCopy = (): string => {
+    if (formattedLastRunTime != null) {
+      return i18n.format(
+        `${terminationTypeMap[runData.status] ?? ''} ${formattedLastRunTime}`,
+        'capitalize'
+      )
+    } else {
+      return ''
     }
-  ).replace('about ', '')
+  }
 
   return isProtocolFetching || isLookingForHardware ? (
     <Skeleton
@@ -227,10 +234,7 @@ export function ProtocolWithLastRun({
         lineHeight={TYPOGRAPHY.lineHeight28}
         color={COLORS.grey60}
       >
-        {i18n.format(
-          `${terminationTypeMap[runData.status] ?? ''} ${formattedLastRunTime}`,
-          'capitalize'
-        )}
+        {buildLastRunCopy()}
       </LegacyStyledText>
     </Flex>
   )