Skip to content

Commit

Permalink
fix load-file ingredients type
Browse files Browse the repository at this point in the history
  • Loading branch information
jerader committed Feb 5, 2025
1 parent 1f240e0 commit 6b63aae
Show file tree
Hide file tree
Showing 7 changed files with 18 additions and 17 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,10 @@
"ingredients": {
"0": {
"displayName": "Water",
"displayColor": "#b925ff",
"description": null,
"liquidGroupId": "0",
"pythonName": "liquid_1",
"displayColor": "#b925ff"
"liquidGroupId": "0"
}
},
"ingredLocations": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,10 @@
"ingredients": {
"0": {
"displayName": "Water",
"displayColor": "#b925ff",
"description": null,
"liquidGroupId": "0",
"pythonName": "liquid_1",
"displayColor": "#b925ff"
"liquidGroupId": "0"
}
},
"ingredLocations": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,17 +37,17 @@
"ingredients": {
"0": {
"displayName": "Water",
"displayColor": "#b925ff",
"description": null,
"liquidGroupId": "0",
"pythonName": "liquid_1",
"displayColor": "#b925ff"
"liquidGroupId": "0"
},
"1": {
"displayName": "Samples",
"displayColor": "#ffd600",
"description": null,
"liquidGroupId": "1",
"pythonName": "liquid_2",
"displayColor": "#ffd600"
"liquidGroupId": "1"
}
},
"ingredLocations": {
Expand Down
4 changes: 2 additions & 2 deletions protocol-designer/fixtures/protocol/8/doItAllV8.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,14 @@
},
"ingredients": {
"0": {
"displayName": "",
"displayName": "h20",
"description": null,
"liquidGroupId": "0",
"pythonName": "liquid_1",
"displayColor": "#b925ff"
},
"1": {
"displayName": "",
"displayName": "sample",
"description": null,
"liquidGroupId": "1",
"pythonName": "liquid_2",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,16 +38,16 @@
"0": {
"displayName": "samples",
"description": null,
"liquidGroupId": "0",
"displayColor": "#b925ff",
"pythonName": "liquid_1",
"displayColor": "#b925ff"
"liquidGroupId": "0"
},
"1": {
"displayName": "dna",
"description": null,
"liquidGroupId": "1",
"pythonName": "liquid_2",
"displayColor": "#ffd600"
"displayColor": "#ffd600",
"liquidGroupId": "1"
}
},
"ingredLocations": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,10 @@
"ingredients": {
"0": {
"displayName": "123",
"displayColor": "#b925ff",
"description": null,
"liquidGroupId": "0",
"pythonName": "liquid_1",
"displayColor": "#b925ff"
"liquidGroupId": "0"
}
},
"ingredLocations": {
Expand Down
3 changes: 2 additions & 1 deletion protocol-designer/src/file-types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,13 @@ import type { ProtocolFile as ProtocolFileV3 } from '@opentrons/shared-data/prot
import type { ProtocolFile as ProtocolFileV4 } from '@opentrons/shared-data/protocol/types/schemaV4'
import type { ProtocolFile as ProtocolFileV5 } from '@opentrons/shared-data/protocol/types/schemaV5'
import type { ProtocolFile as ProtocolFileV6 } from '@opentrons/shared-data/protocol/types/schemaV6'
import { LiquidEntities } from '@opentrons/step-generation'

Check failure on line 8 in protocol-designer/src/file-types.ts

View workflow job for this annotation

GitHub Actions / js checks

All imports in the declaration are only used as types. Use `import type`

Check failure on line 8 in protocol-designer/src/file-types.ts

View workflow job for this annotation

GitHub Actions / js checks

All imports in the declaration are only used as types. Use `import type`

export interface PDMetadata {
// pipetteId to tiprackModel
pipetteTiprackAssignments: Record<string, string[]>
dismissedWarnings: DismissRoot['dismissedWarnings']
ingredients: IngredRoot['ingredients']
ingredients: LiquidEntities
ingredLocations: IngredRoot['ingredLocations']
savedStepForms: StepformRoot['savedStepForms']
orderedStepIds: StepformRoot['orderedStepIds']
Expand Down

0 comments on commit 6b63aae

Please sign in to comment.